Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-30 Thread Marek Vasut
On Thursday, July 30, 2015 at 02:18:09 PM, Michal Suchanek wrote: > On 30 July 2015 at 13:24, Marek Vasut wrote: > > On Monday, July 27, 2015 at 10:43:05 PM, Michal Suchanek wrote: > >> On 27 July 2015 at 19:43, Marek Vasut wrote: > >> > On Monday, July 27, 2015 at 11:46:25 AM, Michal Suchanek wr

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-30 Thread Michal Suchanek
On 30 July 2015 at 13:24, Marek Vasut wrote: > On Monday, July 27, 2015 at 10:43:05 PM, Michal Suchanek wrote: >> On 27 July 2015 at 19:43, Marek Vasut wrote: >> > On Monday, July 27, 2015 at 11:46:25 AM, Michal Suchanek wrote: >> >> On 24 July 2015 at 10:34, Marek Vasut wrote: >> >> > On Thursd

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-30 Thread Marek Vasut
On Monday, July 27, 2015 at 10:43:05 PM, Michal Suchanek wrote: > On 27 July 2015 at 19:43, Marek Vasut wrote: > > On Monday, July 27, 2015 at 11:46:25 AM, Michal Suchanek wrote: > >> On 24 July 2015 at 10:34, Marek Vasut wrote: > >> > On Thursday, July 23, 2015 at 07:03:47 PM, Michal Suchanek wr

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-27 Thread Michal Suchanek
On 27 July 2015 at 19:43, Marek Vasut wrote: > On Monday, July 27, 2015 at 11:46:25 AM, Michal Suchanek wrote: >> On 24 July 2015 at 10:34, Marek Vasut wrote: >> > On Thursday, July 23, 2015 at 07:03:47 PM, Michal Suchanek wrote: >> > >> Ok, so here is some summary. >> >> I have a NOR flash attac

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-27 Thread Marek Vasut
On Monday, July 27, 2015 at 11:46:25 AM, Michal Suchanek wrote: > On 24 July 2015 at 10:34, Marek Vasut wrote: > > On Thursday, July 23, 2015 at 07:03:47 PM, Michal Suchanek wrote: > > > > Hi! > > > > [...] > > > >> >>> It's probably slower to set up DMA for 2-byte commands but it might > >> >>

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-27 Thread Michal Suchanek
On 24 July 2015 at 10:34, Marek Vasut wrote: > On Thursday, July 23, 2015 at 07:03:47 PM, Michal Suchanek wrote: > > Hi! > > [...] > >> >>> It's probably slower to set up DMA for 2-byte commands but it might >> >>> work nonetheless. >> >> >> >> It is, the overhead will be considerable. It might he

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-24 Thread Michal Suchanek
On 24 July 2015 at 10:34, Marek Vasut wrote: > On Thursday, July 23, 2015 at 07:03:47 PM, Michal Suchanek wrote: > > Hi! > > [...] > >> >>> It's probably slower to set up DMA for 2-byte commands but it might >> >>> work nonetheless. >> >> >> >> It is, the overhead will be considerable. It might he

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-24 Thread Marek Vasut
On Thursday, July 23, 2015 at 07:03:47 PM, Michal Suchanek wrote: Hi! [...] > >>> It's probably slower to set up DMA for 2-byte commands but it might > >>> work nonetheless. > >> > >> It is, the overhead will be considerable. It might help the stability > >> though. I'm really looking forward t

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-23 Thread Michal Suchanek
On 23 July 2015 at 18:46, Michal Suchanek wrote: > On 22 July 2015 at 11:01, Marek Vasut wrote: >> On Wednesday, July 22, 2015 at 10:38:14 AM, Michal Suchanek wrote: >>> On 22 July 2015 at 10:24, Marek Vasut wrote: >>> > On Wednesday, July 22, 2015 at 10:18:04 AM, Michal Suchanek wrote: >>> >> O

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-23 Thread Michal Suchanek
On 22 July 2015 at 11:01, Marek Vasut wrote: > On Wednesday, July 22, 2015 at 10:38:14 AM, Michal Suchanek wrote: >> On 22 July 2015 at 10:24, Marek Vasut wrote: >> > On Wednesday, July 22, 2015 at 10:18:04 AM, Michal Suchanek wrote: >> >> On 22 July 2015 at 09:58, Marek Vasut wrote: >> >> > On

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Marek Vasut
On Wednesday, July 22, 2015 at 10:38:14 AM, Michal Suchanek wrote: > On 22 July 2015 at 10:24, Marek Vasut wrote: > > On Wednesday, July 22, 2015 at 10:18:04 AM, Michal Suchanek wrote: > >> On 22 July 2015 at 09:58, Marek Vasut wrote: > >> > On Wednesday, July 22, 2015 at 09:45:27 AM, Michal Such

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Michal Suchanek
On 22 July 2015 at 10:24, Marek Vasut wrote: > On Wednesday, July 22, 2015 at 10:18:04 AM, Michal Suchanek wrote: >> On 22 July 2015 at 09:58, Marek Vasut wrote: >> > On Wednesday, July 22, 2015 at 09:45:27 AM, Michal Suchanek wrote: >> >> On 22 July 2015 at 09:33, Marek Vasut wrote: >> >> > On

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Marek Vasut
On Wednesday, July 22, 2015 at 10:18:04 AM, Michal Suchanek wrote: > On 22 July 2015 at 09:58, Marek Vasut wrote: > > On Wednesday, July 22, 2015 at 09:45:27 AM, Michal Suchanek wrote: > >> On 22 July 2015 at 09:33, Marek Vasut wrote: > >> > On Wednesday, July 22, 2015 at 09:30:54 AM, Michal Such

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Michal Suchanek
On 22 July 2015 at 09:58, Marek Vasut wrote: > On Wednesday, July 22, 2015 at 09:45:27 AM, Michal Suchanek wrote: >> On 22 July 2015 at 09:33, Marek Vasut wrote: >> > On Wednesday, July 22, 2015 at 09:30:54 AM, Michal Suchanek wrote: >> >> On 22 July 2015 at 06:49, Vinod Koul wrote: >> >> > On T

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Marek Vasut
On Wednesday, July 22, 2015 at 09:45:27 AM, Michal Suchanek wrote: > On 22 July 2015 at 09:33, Marek Vasut wrote: > > On Wednesday, July 22, 2015 at 09:30:54 AM, Michal Suchanek wrote: > >> On 22 July 2015 at 06:49, Vinod Koul wrote: > >> > On Tue, Jul 21, 2015 at 10:14:11AM +0200, Michal Suchane

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Michal Suchanek
On 22 July 2015 at 09:33, Marek Vasut wrote: > On Wednesday, July 22, 2015 at 09:30:54 AM, Michal Suchanek wrote: >> On 22 July 2015 at 06:49, Vinod Koul wrote: >> > On Tue, Jul 21, 2015 at 10:14:11AM +0200, Michal Suchanek wrote: >> >> > Or alternatively we could publish the limitations of the c

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Marek Vasut
On Wednesday, July 22, 2015 at 09:30:54 AM, Michal Suchanek wrote: > On 22 July 2015 at 06:49, Vinod Koul wrote: > > On Tue, Jul 21, 2015 at 10:14:11AM +0200, Michal Suchanek wrote: > >> > Or alternatively we could publish the limitations of the channel using > >> > capabilities so SPI knows I hav

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-22 Thread Michal Suchanek
On 22 July 2015 at 06:49, Vinod Koul wrote: > On Tue, Jul 21, 2015 at 10:14:11AM +0200, Michal Suchanek wrote: >> > Or alternatively we could publish the limitations of the channel using >> > capabilities so SPI knows I have a dmaengine channel and it can transfer >> > max N >> > length transfers

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-21 Thread Vinod Koul
On Tue, Jul 21, 2015 at 10:14:11AM +0200, Michal Suchanek wrote: > > Or alternatively we could publish the limitations of the channel using > > capabilities so SPI knows I have a dmaengine channel and it can transfer > > max N > > length transfers so would be able to break rather than guessing it

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-21 Thread Michal Suchanek
Hello, On 21 July 2015 at 06:29, Vinod Koul wrote: > On Sun, Jul 19, 2015 at 09:01:34PM +0200, Michal Suchanek wrote: >> Hello, >> >> On 15 July 2015 at 17:59, Brian Norris wrote: >> > Hi Michal, >> > >> > On Wed, Jul 15, 2015 at 01:52:27PM +0200, Marek Vasut wrote: >> >> The problem is, if you

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-20 Thread Vinod Koul
On Sun, Jul 19, 2015 at 09:01:34PM +0200, Michal Suchanek wrote: > Hello, > > On 15 July 2015 at 17:59, Brian Norris wrote: > > Hi Michal, > > > > On Wed, Jul 15, 2015 at 01:52:27PM +0200, Marek Vasut wrote: > >> The problem is, if you add a new DT binding, you'd have to support it > >> forever,

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-19 Thread Michal Suchanek
Hello, On 15 July 2015 at 17:59, Brian Norris wrote: > Hi Michal, > > On Wed, Jul 15, 2015 at 01:52:27PM +0200, Marek Vasut wrote: >> The problem is, if you add a new DT binding, you'd have to support it >> forever, no matter how bad idea that binding turned out to be. > > Agreed, and a solid NAK

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-15 Thread Marek Vasut
On Thursday, July 16, 2015 at 03:19:35 AM, Brian Norris wrote: > On Wed, Jul 15, 2015 at 07:15:50PM +0200, Marek Vasut wrote: > > On Wednesday, July 15, 2015 at 05:59:46 PM, Brian Norris wrote: > > > 1. Fix up the SPI driver so that it knows how to break large SPI > > > transfers up into smaller se

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-15 Thread Brian Norris
On Wed, Jul 15, 2015 at 07:15:50PM +0200, Marek Vasut wrote: > On Wednesday, July 15, 2015 at 05:59:46 PM, Brian Norris wrote: > > 1. Fix up the SPI driver so that it knows how to break large SPI > > transfers up into smaller segments that its constituent hardware (DMA > > controllers, fast clocks,

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-15 Thread Marek Vasut
On Wednesday, July 15, 2015 at 05:59:46 PM, Brian Norris wrote: > Hi Michal, Hi all, > On Wed, Jul 15, 2015 at 01:52:27PM +0200, Marek Vasut wrote: > > The problem is, if you add a new DT binding, you'd have to support it > > forever, no matter how bad idea that binding turned out to be. > > Agr

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-15 Thread Brian Norris
Hi Michal, On Wed, Jul 15, 2015 at 01:52:27PM +0200, Marek Vasut wrote: > The problem is, if you add a new DT binding, you'd have to support it > forever, no matter how bad idea that binding turned out to be. Agreed, and a solid NAK to this patch. I could have sworn I gave such a response when th

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-15 Thread Marek Vasut
On Wednesday, July 15, 2015 at 11:45:07 AM, Michal Suchanek wrote: > On 4 June 2015 at 19:15, Richard Cochran wrote: > > On Thu, Jun 04, 2015 at 10:31:45AM +0200, Michal Suchanek wrote: > >> You might want to try to run the bus at 60MHz or 80MHz and then the > >> values would probably again be dif

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-07-15 Thread Michal Suchanek
On 4 June 2015 at 19:15, Richard Cochran wrote: > On Thu, Jun 04, 2015 at 10:31:45AM +0200, Michal Suchanek wrote: >> You might want to try to run the bus at 60MHz or 80MHz and then the >> values would probably again be different. >> >> The first two values are set in DT so the logical place for s

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-06-04 Thread Richard Cochran
On Thu, Jun 04, 2015 at 10:31:45AM +0200, Michal Suchanek wrote: > You might want to try to run the bus at 60MHz or 80MHz and then the > values would probably again be different. > > The first two values are set in DT so the logical place for setting > the third is also in DT. > > Otherwise you w

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-06-04 Thread Marek Vasut
On Thursday, June 04, 2015 at 06:31:45 AM, Michal Suchanek wrote: > On 4 June 2015 at 01:03, Marek Vasut wrote: > > On Wednesday, June 03, 2015 at 11:26:41 PM, Michal Suchanek wrote: > >> On sunxi the SPI controller currently does not have DMA support and > >> fails any transfer larger than 63 byt

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-06-04 Thread Michal Suchanek
On 4 June 2015 at 08:42, Geert Uytterhoeven wrote: > On Wed, Jun 3, 2015 at 11:26 PM, Michal Suchanek wrote: >> On sunxi the SPI controller currently does not have DMA support and fails >> any transfer larger than 63 bytes. > > This is a driver limitation, not a hardware limitation. > >> On Exyno

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-06-03 Thread Geert Uytterhoeven
On Wed, Jun 3, 2015 at 11:26 PM, Michal Suchanek wrote: > On sunxi the SPI controller currently does not have DMA support and fails > any transfer larger than 63 bytes. This is a driver limitation, not a hardware limitation. > On Exynos the pl330 DMA controller fails any transfer larger than 64k

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-06-03 Thread Michal Suchanek
On 4 June 2015 at 01:03, Marek Vasut wrote: > On Wednesday, June 03, 2015 at 11:26:41 PM, Michal Suchanek wrote: >> On sunxi the SPI controller currently does not have DMA support and fails >> any transfer larger than 63 bytes. >> >> On Exynos the pl330 DMA controller fails any transfer larger tha

Re: [PATCH 08/11] MTD: m25p80: Add option to limit SPI transfer size.

2015-06-03 Thread Marek Vasut
On Wednesday, June 03, 2015 at 11:26:41 PM, Michal Suchanek wrote: > On sunxi the SPI controller currently does not have DMA support and fails > any transfer larger than 63 bytes. > > On Exynos the pl330 DMA controller fails any transfer larger than 64kb > when using slower speed like 40MHz and an