Re: [PATCH 08/11] signal/arm: Document conflicts with SI_USER and SIGFPE

2018-01-19 Thread Dave Martin
On Mon, Jan 15, 2018 at 05:49:47PM +, Russell King - ARM Linux wrote: > On Thu, Jan 11, 2018 at 06:59:37PM -0600, Eric W. Biederman wrote: > > Setting si_code to 0 results in a userspace seeing an si_code of 0. > > This is the same si_code as SI_USER. Posix and common sense requires > > that S

Re: [PATCH 08/11] signal/arm: Document conflicts with SI_USER and SIGFPE

2018-01-16 Thread Dave Martin
On Mon, Jan 15, 2018 at 05:49:47PM +, Russell King - ARM Linux wrote: > On Thu, Jan 11, 2018 at 06:59:37PM -0600, Eric W. Biederman wrote: > > Setting si_code to 0 results in a userspace seeing an si_code of 0. > > This is the same si_code as SI_USER. Posix and common sense requires > > that S

Re: [PATCH 08/11] signal/arm: Document conflicts with SI_USER and SIGFPE

2018-01-15 Thread Eric W. Biederman
Russell King - ARM Linux writes: > On Thu, Jan 11, 2018 at 06:59:37PM -0600, Eric W. Biederman wrote: >> Setting si_code to 0 results in a userspace seeing an si_code of 0. >> This is the same si_code as SI_USER. Posix and common sense requires >> that SI_USER not be a signal specific si_code.

Re: [PATCH 08/11] signal/arm: Document conflicts with SI_USER and SIGFPE

2018-01-15 Thread Russell King - ARM Linux
On Thu, Jan 11, 2018 at 06:59:37PM -0600, Eric W. Biederman wrote: > Setting si_code to 0 results in a userspace seeing an si_code of 0. > This is the same si_code as SI_USER. Posix and common sense requires > that SI_USER not be a signal specific si_code. As such this use of 0 > for the si_code

[PATCH 08/11] signal/arm: Document conflicts with SI_USER and SIGFPE

2018-01-11 Thread Eric W. Biederman
Setting si_code to 0 results in a userspace seeing an si_code of 0. This is the same si_code as SI_USER. Posix and common sense requires that SI_USER not be a signal specific si_code. As such this use of 0 for the si_code is a pretty horribly broken ABI. Further use of si_code == 0 guaranteed th