Re: [PATCH 08/12] time: Add warnings when overflows or underflows are observed

2015-03-09 Thread Ingo Molnar
* John Stultz wrote: > Thanks Ingo for the very close review, and apologies for my poor > keyboardmanship (I hope I didn't burn much of your good will here). No problem. I usually fix typos up when the patch is otherwise good, except for Git pulls, where I cannot, so I'm pushing back ... >

Re: [PATCH 08/12] time: Add warnings when overflows or underflows are observed

2015-03-09 Thread John Stultz
On Sat, Mar 7, 2015 at 1:40 AM, Ingo Molnar wrote: ... > > Typo. ... > > Typo. > ... > > Typo. > ... > > Typo... > ... > > Spurious space. I know they are cheap, but still. And a big D with a circle around it. Back to grade-school with me. :) Thanks Ingo for the very close review, and apologies

Re: [PATCH 08/12] time: Add warnings when overflows or underflows are observed

2015-03-09 Thread John Stultz
On Sat, Mar 7, 2015 at 1:40 AM, Ingo Molnar mi...@kernel.org wrote: ... Typo. ... Typo. ... Typo. ... Typo... ... Spurious space. I know they are cheap, but still. And a big D with a circle around it. Back to grade-school with me. :) Thanks Ingo for the very close review, and

Re: [PATCH 08/12] time: Add warnings when overflows or underflows are observed

2015-03-09 Thread Ingo Molnar
* John Stultz john.stu...@linaro.org wrote: Thanks Ingo for the very close review, and apologies for my poor keyboardmanship (I hope I didn't burn much of your good will here). No problem. I usually fix typos up when the patch is otherwise good, except for Git pulls, where I cannot, so I'm

Re: [PATCH 08/12] time: Add warnings when overflows or underflows are observed

2015-03-07 Thread Ingo Molnar
* John Stultz wrote: > It was suggested that the underflow/overflow protection > should probably throw some sort of warning out, rather > then just silently fixing the issue. Typo. > So this patch adds some warnings here. The flag variables > used are not protected by locks, but since we

Re: [PATCH 08/12] time: Add warnings when overflows or underflows are observed

2015-03-07 Thread Ingo Molnar
* John Stultz john.stu...@linaro.org wrote: It was suggested that the underflow/overflow protection should probably throw some sort of warning out, rather then just silently fixing the issue. Typo. So this patch adds some warnings here. The flag variables used are not protected by locks,

[PATCH 08/12] time: Add warnings when overflows or underflows are observed

2015-03-06 Thread John Stultz
It was suggested that the underflow/overflow protection should probably throw some sort of warning out, rather then just silently fixing the issue. So this patch adds some warnings here. The flag variables used are not protected by locks, but since we can't print from the reading functions, just

[PATCH 08/12] time: Add warnings when overflows or underflows are observed

2015-03-06 Thread John Stultz
It was suggested that the underflow/overflow protection should probably throw some sort of warning out, rather then just silently fixing the issue. So this patch adds some warnings here. The flag variables used are not protected by locks, but since we can't print from the reading functions, just

Re: [PATCH 08/12] time: Add warnings when overflows or underflows are observed

2015-01-23 Thread Peter Zijlstra
On Thu, Jan 22, 2015 at 04:09:23PM -0800, John Stultz wrote: > #ifdef CONFIG_DEBUG_TIMEKEEPING > +#define WARNINGFREQ (HZ*300) /* 5 minute rate-limiting */ > +/* > + * These simple flag variables are managed > + * without locks, which is racy, but ok since > + * we don't really care about being

Re: [PATCH 08/12] time: Add warnings when overflows or underflows are observed

2015-01-23 Thread Peter Zijlstra
On Thu, Jan 22, 2015 at 04:09:23PM -0800, John Stultz wrote: #ifdef CONFIG_DEBUG_TIMEKEEPING +#define WARNINGFREQ (HZ*300) /* 5 minute rate-limiting */ +/* + * These simple flag variables are managed + * without locks, which is racy, but ok since + * we don't really care about being super

[PATCH 08/12] time: Add warnings when overflows or underflows are observed

2015-01-22 Thread John Stultz
It was suggested that the underflow/overflow protection should probably throw some sort of warning out, rather then just silently fixing the issue. So this patch adds some warnings here. The flag variables used are not protected by locks, but since we can't print from the reading functions, just

[PATCH 08/12] time: Add warnings when overflows or underflows are observed

2015-01-22 Thread John Stultz
It was suggested that the underflow/overflow protection should probably throw some sort of warning out, rather then just silently fixing the issue. So this patch adds some warnings here. The flag variables used are not protected by locks, but since we can't print from the reading functions, just