Re: [PATCH 08/15] hisi_sas: fix a potential warning for sata disk ejection

2016-09-14 Thread Hannes Reinecke
On 09/06/2016 05:36 PM, John Garry wrote: > If hisi_sas_task_prep() fails for a SATA device due to PHY > down, we return a failure to libata and also call task_done(), > which will cause ata_qc_complete() to be called twice: > - first call from hisi_sas_task_prep(), which will clear flag > ATA_QC

[PATCH 08/15] hisi_sas: fix a potential warning for sata disk ejection

2016-09-06 Thread John Garry
If hisi_sas_task_prep() fails for a SATA device due to PHY down, we return a failure to libata and also call task_done(), which will cause ata_qc_complete() to be called twice: - first call from hisi_sas_task_prep(), which will clear flag ATA_QCFLAG_ACTIVE - ata_qc_complete() called from libata T