From: Arnaldo Carvalho de Melo <a...@redhat.com>

All tools will want those, so provide a convenient way to get them.

Cc: Adrian Hunter <adrian.hun...@intel.com>
Cc: Florian Weimer <fwei...@redhat.com>
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: William Cohen <wco...@redhat.com>
Link: https://lkml.kernel.org/n/tip-v16pe3sbf3wjmn152u18f...@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com>
---
 tools/perf/builtin-script.c | 7 +------
 tools/perf/util/evswitch.h  | 8 ++++++++
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 177e4e91b199..2a5b8af80e6b 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -3543,12 +3543,7 @@ int cmd_script(int argc, const char **argv)
                   "file", "file saving guest os /proc/kallsyms"),
        OPT_STRING(0, "guestmodules", &symbol_conf.default_guest_modules,
                   "file", "file saving guest os /proc/modules"),
-       OPT_STRING(0, "switch-on", &script.evswitch.on_name,
-                  "event", "Consider events after the ocurrence of this 
event"),
-       OPT_STRING(0, "switch-off", &script.evswitch.off_name,
-                  "event", "Stop considering events after the ocurrence of 
this event"),
-       OPT_BOOLEAN(0, "show-on-off-events", 
&script.evswitch.show_on_off_events,
-                   "Show the on/off switch events, used with --switch-on"),
+       OPTS_EVSWITCH(&script.evswitch),
        OPT_END()
        };
        const char * const script_subcommands[] = { "record", "report", NULL };
diff --git a/tools/perf/util/evswitch.h b/tools/perf/util/evswitch.h
index 891164504080..94220d1bb479 100644
--- a/tools/perf/util/evswitch.h
+++ b/tools/perf/util/evswitch.h
@@ -16,4 +16,12 @@ struct evswitch {
 
 bool evswitch__discard(struct evswitch *evswitch, struct evsel *evsel);
 
+#define OPTS_EVSWITCH(evswitch)                                                
                  \
+       OPT_STRING(0, "switch-on", &(evswitch)->on_name,                        
          \
+                  "event", "Consider events after the ocurrence of this 
event"),         \
+       OPT_STRING(0, "switch-off", &(evswitch)->off_name,                      
          \
+                  "event", "Stop considering events after the ocurrence of 
this event"), \
+       OPT_BOOLEAN(0, "show-on-off-events", &(evswitch)->show_on_off_events,   
          \
+                   "Show the on/off switch events, used with --switch-on and 
--switch-off")
+
 #endif /* __PERF_EVSWITCH_H */
-- 
2.21.0

Reply via email to