Re: [PATCH 08/21] NTB: declare unused variables

2013-01-21 Thread Greg KH
On Mon, Jan 21, 2013 at 10:50:55AM -0700, Jon Mason wrote: > On Sun, Jan 20, 2013 at 03:42:28PM -0800, Greg KH wrote: > > On Sat, Jan 19, 2013 at 02:02:22AM -0700, Jon Mason wrote: > > > Tag pci_device_id in ntb_pci_probe as unused function parameters. This > > > corrects issues found by 'EXTRA_CF

Re: [PATCH 08/21] NTB: declare unused variables

2013-01-21 Thread Jon Mason
On Sun, Jan 20, 2013 at 03:42:28PM -0800, Greg KH wrote: > On Sat, Jan 19, 2013 at 02:02:22AM -0700, Jon Mason wrote: > > Tag pci_device_id in ntb_pci_probe as unused function parameters. This > > corrects issues found by 'EXTRA_CFLAGS=-W'. > > Why would you build the kernel with that option? Th

Re: [PATCH 08/21] NTB: declare unused variables

2013-01-20 Thread Greg KH
On Sat, Jan 19, 2013 at 02:02:22AM -0700, Jon Mason wrote: > Tag pci_device_id in ntb_pci_probe as unused function parameters. This > corrects issues found by 'EXTRA_CFLAGS=-W'. Why would you build the kernel with that option? This isn't needed, so I'm not going to apply it. thanks, greg k-h -

[PATCH 08/21] NTB: declare unused variables

2013-01-19 Thread Jon Mason
Tag pci_device_id in ntb_pci_probe as unused function parameters. This corrects issues found by 'EXTRA_CFLAGS=-W'. Signed-off-by: Jon Mason --- drivers/ntb/ntb_hw.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c index 867ccaa