Re: [PATCH 08/30] KVM: nSVM: move map argument out of enter_svm_guest_mode

2020-05-29 Thread Krish Sadhukhan
On 5/29/20 12:04 PM, Paolo Bonzini wrote: On 29/05/20 20:10, Krish Sadhukhan wrote: Unmapping the nested VMCB in enter_svm_guest_mode is a bit of a wart, since the map is not used elsewhere in the function.  There are just two calls, so move it there. The last sentence sounds bit incomplete.

Re: [PATCH 08/30] KVM: nSVM: move map argument out of enter_svm_guest_mode

2020-05-29 Thread Paolo Bonzini
On 29/05/20 20:10, Krish Sadhukhan wrote: >> Unmapping the nested VMCB in enter_svm_guest_mode is a bit of a wart, >> since the map is not used elsewhere in the function.  There are >> just two calls, so move it there. > > The last sentence sounds bit incomplete. Good point---more precisely, "cal

Re: [PATCH 08/30] KVM: nSVM: move map argument out of enter_svm_guest_mode

2020-05-29 Thread Krish Sadhukhan
On 5/29/20 8:39 AM, Paolo Bonzini wrote: Unmapping the nested VMCB in enter_svm_guest_mode is a bit of a wart, since the map is not used elsewhere in the function. There are just two calls, so move it there. The last sentence sounds bit incomplete. Also, does it make sense to mention the r

[PATCH 08/30] KVM: nSVM: move map argument out of enter_svm_guest_mode

2020-05-29 Thread Paolo Bonzini
Unmapping the nested VMCB in enter_svm_guest_mode is a bit of a wart, since the map is not used elsewhere in the function. There are just two calls, so move it there. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/svm/nested.c | 14 ++ arch/x86/kvm/svm/svm.c| 3 ++- arch/x86/kvm