Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-27 Thread Kalle Valo
Lee Jones writes: > On Mon, 17 Aug 2020, Kalle Valo wrote: > >> Rasmus Villemoes writes: >> >> > On 14/08/2020 17.14, Christian Lamparter wrote: >> >> On 2020-08-14 13:39, Lee Jones wrote: >> >>> 'ar9170_qmap' is used in some source files which include carl9170.h, >> >>> but not all of them.  M

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-18 Thread Lee Jones
On Mon, 17 Aug 2020, Kalle Valo wrote: > Rasmus Villemoes writes: > > > On 14/08/2020 17.14, Christian Lamparter wrote: > >> On 2020-08-14 13:39, Lee Jones wrote: > >>> 'ar9170_qmap' is used in some source files which include carl9170.h, > >>> but not all of them.  Mark it as __maybe_unused to s

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-17 Thread Christian Lamparter
On 2020-08-17 14:59, Kalle Valo wrote: Rasmus Villemoes writes: On 14/08/2020 17.14, Christian Lamparter wrote: On 2020-08-14 13:39, Lee Jones wrote: 'ar9170_qmap' is used in some source files which include carl9170.h, but not all of them.  Mark it as __maybe_unused to show that this is not

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-17 Thread Kalle Valo
Rasmus Villemoes writes: > On 14/08/2020 17.14, Christian Lamparter wrote: >> On 2020-08-14 13:39, Lee Jones wrote: >>> 'ar9170_qmap' is used in some source files which include carl9170.h, >>> but not all of them.  Mark it as __maybe_unused to show that this is >>> not only okay, it's expected. >

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-17 Thread Lee Jones
On Fri, 14 Aug 2020, Christian Lamparter wrote: > On 2020-08-14 18:40, Lee Jones wrote: > > On Fri, 14 Aug 2020, Christian Lamparter wrote: > > > > > On 2020-08-14 13:39, Lee Jones wrote: > > > > 'ar9170_qmap' is used in some source files which include carl9170.h, > > > > but not all of them. Ma

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-17 Thread Rasmus Villemoes
On 14/08/2020 17.14, Christian Lamparter wrote: > On 2020-08-14 13:39, Lee Jones wrote: >> 'ar9170_qmap' is used in some source files which include carl9170.h, >> but not all of them.  Mark it as __maybe_unused to show that this is >> not only okay, it's expected. >> >> Fixes the following W=1 kern

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-14 Thread Christian Lamparter
On 2020-08-14 18:40, Lee Jones wrote: On Fri, 14 Aug 2020, Christian Lamparter wrote: On 2020-08-14 13:39, Lee Jones wrote: 'ar9170_qmap' is used in some source files which include carl9170.h, but not all of them. Mark it as __maybe_unused to show that this is not only okay, it's expected. F

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-14 Thread Lee Jones
On Fri, 14 Aug 2020, Christian Lamparter wrote: > On 2020-08-14 13:39, Lee Jones wrote: > > 'ar9170_qmap' is used in some source files which include carl9170.h, > > but not all of them. Mark it as __maybe_unused to show that this is > > not only okay, it's expected. > > > > Fixes the following W

Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-14 Thread Christian Lamparter
On 2020-08-14 13:39, Lee Jones wrote: 'ar9170_qmap' is used in some source files which include carl9170.h, but not all of them. Mark it as __maybe_unused to show that this is not only okay, it's expected. Fixes the following W=1 kernel build warning(s) Is this W=1 really a "must" requirement?

[PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused

2020-08-14 Thread Lee Jones
'ar9170_qmap' is used in some source files which include carl9170.h, but not all of them. Mark it as __maybe_unused to show that this is not only okay, it's expected. Fixes the following W=1 kernel build warning(s) from drivers/net/wireless/ath/carl9170/carl9170.h:57, In file included from dri