Re: [PATCH 08/37] cputime: Convert task/group cputime to nsecs

2017-01-30 Thread Frederic Weisbecker
On Mon, Jan 30, 2017 at 02:54:51PM +0100, Stanislaw Gruszka wrote: > On Sat, Jan 28, 2017 at 04:28:13PM +0100, Frederic Weisbecker wrote: > > On Sat, Jan 28, 2017 at 12:57:40PM +0100, Stanislaw Gruszka wrote: > > > On 32 bit architectures 64bit store/load is not atomic and if not > > > protected -

Re: [PATCH 08/37] cputime: Convert task/group cputime to nsecs

2017-01-30 Thread Stanislaw Gruszka
On Sat, Jan 28, 2017 at 04:28:13PM +0100, Frederic Weisbecker wrote: > On Sat, Jan 28, 2017 at 12:57:40PM +0100, Stanislaw Gruszka wrote: > > On 32 bit architectures 64bit store/load is not atomic and if not > > protected - 64bit variables can be mangled. I do not see any protection > > (lock) betw

Re: [PATCH 08/37] cputime: Convert task/group cputime to nsecs

2017-01-28 Thread Frederic Weisbecker
On Sat, Jan 28, 2017 at 12:57:40PM +0100, Stanislaw Gruszka wrote: > Hi Frederic and sorry for late comment. > > On Sun, Jan 22, 2017 at 07:19:44PM +0100, Frederic Weisbecker wrote: > > Now that most cputime readers use the transition API which return the > > task cputime in old style cputime_t, w

Re: [PATCH 08/37] cputime: Convert task/group cputime to nsecs

2017-01-28 Thread Stanislaw Gruszka
Hi Frederic and sorry for late comment. On Sun, Jan 22, 2017 at 07:19:44PM +0100, Frederic Weisbecker wrote: > Now that most cputime readers use the transition API which return the > task cputime in old style cputime_t, we can safely store the cputime in > nsecs. This will eventually make cputime

[PATCH 08/37] cputime: Convert task/group cputime to nsecs

2017-01-22 Thread Frederic Weisbecker
Now that most cputime readers use the transition API which return the task cputime in old style cputime_t, we can safely store the cputime in nsecs. This will eventually make cputime statistics less opaque and more granular. Back and forth convertions between cputime_t and nsecs in order to deal wi