Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-10 Thread Liviu Dudau
On Wed, Apr 10, 2019 at 03:23:39PM +0530, Vidya Sagar wrote: > On 4/10/2019 1:44 PM, Liviu Dudau wrote: > > On Wed, Apr 10, 2019 at 11:40:40AM +0530, Vidya Sagar wrote: > > > On 4/9/2019 6:56 PM, Bjorn Helgaas wrote: > > > > On Tue, Apr 09, 2019 at 05:00:53PM +0530, Vidya Sagar wrote: > > > > > On

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-10 Thread Vidya Sagar
On 4/10/2019 1:44 PM, Liviu Dudau wrote: On Wed, Apr 10, 2019 at 11:40:40AM +0530, Vidya Sagar wrote: On 4/9/2019 6:56 PM, Bjorn Helgaas wrote: On Tue, Apr 09, 2019 at 05:00:53PM +0530, Vidya Sagar wrote: On 4/6/2019 12:28 AM, Bjorn Helgaas wrote: On Fri, Apr 05, 2019 at 01:23:51AM +0530, Vid

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-10 Thread Liviu Dudau
On Wed, Apr 10, 2019 at 11:40:40AM +0530, Vidya Sagar wrote: > On 4/9/2019 6:56 PM, Bjorn Helgaas wrote: > > On Tue, Apr 09, 2019 at 05:00:53PM +0530, Vidya Sagar wrote: > > > On 4/6/2019 12:28 AM, Bjorn Helgaas wrote: > > > > On Fri, Apr 05, 2019 at 01:23:51AM +0530, Vidya Sagar wrote: > > > > > O

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-09 Thread Vidya Sagar
On 4/9/2019 6:56 PM, Bjorn Helgaas wrote: On Tue, Apr 09, 2019 at 05:00:53PM +0530, Vidya Sagar wrote: On 4/6/2019 12:28 AM, Bjorn Helgaas wrote: On Fri, Apr 05, 2019 at 01:23:51AM +0530, Vidya Sagar wrote: On 4/3/2019 11:06 PM, Bjorn Helgaas wrote: On Wed, Apr 03, 2019 at 03:13:09PM +0530, V

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-09 Thread Bjorn Helgaas
On Tue, Apr 09, 2019 at 05:00:53PM +0530, Vidya Sagar wrote: > On 4/6/2019 12:28 AM, Bjorn Helgaas wrote: > > On Fri, Apr 05, 2019 at 01:23:51AM +0530, Vidya Sagar wrote: > > > On 4/3/2019 11:06 PM, Bjorn Helgaas wrote: > > > > On Wed, Apr 03, 2019 at 03:13:09PM +0530, Vidya Sagar wrote: > > > > >

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-09 Thread Vidya Sagar
On 4/6/2019 12:28 AM, Bjorn Helgaas wrote: On Fri, Apr 05, 2019 at 01:23:51AM +0530, Vidya Sagar wrote: On 4/3/2019 11:06 PM, Bjorn Helgaas wrote: On Wed, Apr 03, 2019 at 03:13:09PM +0530, Vidya Sagar wrote: On 4/3/2019 12:01 AM, Bjorn Helgaas wrote: On Tue, Apr 02, 2019 at 12:47:48PM +0530,

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-05 Thread Bjorn Helgaas
On Fri, Apr 05, 2019 at 01:23:51AM +0530, Vidya Sagar wrote: > On 4/3/2019 11:06 PM, Bjorn Helgaas wrote: > > On Wed, Apr 03, 2019 at 03:13:09PM +0530, Vidya Sagar wrote: > > > On 4/3/2019 12:01 AM, Bjorn Helgaas wrote: > > > > On Tue, Apr 02, 2019 at 12:47:48PM +0530, Vidya Sagar wrote: > > > > >

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-04 Thread Vidya Sagar
On 4/3/2019 11:06 PM, Bjorn Helgaas wrote: On Wed, Apr 03, 2019 at 03:13:09PM +0530, Vidya Sagar wrote: On 4/3/2019 12:01 AM, Bjorn Helgaas wrote: On Tue, Apr 02, 2019 at 12:47:48PM +0530, Vidya Sagar wrote: On 3/30/2019 2:22 AM, Bjorn Helgaas wrote: On Tue, Mar 26, 2019 at 08:43:26PM +0530,

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-03 Thread Bjorn Helgaas
On Wed, Apr 03, 2019 at 03:13:09PM +0530, Vidya Sagar wrote: > On 4/3/2019 12:01 AM, Bjorn Helgaas wrote: > > On Tue, Apr 02, 2019 at 12:47:48PM +0530, Vidya Sagar wrote: > > > On 3/30/2019 2:22 AM, Bjorn Helgaas wrote: > > > > On Tue, Mar 26, 2019 at 08:43:26PM +0530, Vidya Sagar wrote: > > > > >

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-03 Thread Vidya Sagar
On 4/3/2019 12:01 AM, Bjorn Helgaas wrote: On Tue, Apr 02, 2019 at 12:47:48PM +0530, Vidya Sagar wrote: On 3/30/2019 2:22 AM, Bjorn Helgaas wrote: On Tue, Mar 26, 2019 at 08:43:26PM +0530, Vidya Sagar wrote: Add support for Synopsys DesignWare core IP based PCIe host controller present in Tegr

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-03 Thread Vidya Sagar
On 4/2/2019 7:44 PM, Thierry Reding wrote: On Tue, Apr 02, 2019 at 12:47:48PM +0530, Vidya Sagar wrote: On 3/30/2019 2:22 AM, Bjorn Helgaas wrote: [...] +static int tegra_pcie_dw_host_init(struct pcie_port *pp) +{ [...] + val_w = dw_pcie_readw_dbi(pci, CFG_LINK_STATUS); + while (

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-02 Thread Bjorn Helgaas
On Tue, Apr 02, 2019 at 12:47:48PM +0530, Vidya Sagar wrote: > On 3/30/2019 2:22 AM, Bjorn Helgaas wrote: > > On Tue, Mar 26, 2019 at 08:43:26PM +0530, Vidya Sagar wrote: > > > Add support for Synopsys DesignWare core IP based PCIe host controller > > > present in Tegra194 SoC. > > > +#include "..

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-02 Thread Thierry Reding
On Tue, Apr 02, 2019 at 12:47:48PM +0530, Vidya Sagar wrote: > On 3/30/2019 2:22 AM, Bjorn Helgaas wrote: [...] > > > +static int tegra_pcie_dw_host_init(struct pcie_port *pp) > > > +{ [...] > > > + val_w = dw_pcie_readw_dbi(pci, CFG_LINK_STATUS); > > > + while (!(val_w & PCI_EXP_LNKSTA_DLLLA)) { >

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-04-02 Thread Vidya Sagar
On 3/30/2019 2:22 AM, Bjorn Helgaas wrote: Hi Vidya, Wow, there's a lot of nice work here! Thanks for that! On Tue, Mar 26, 2019 at 08:43:26PM +0530, Vidya Sagar wrote: Add support for Synopsys DesignWare core IP based PCIe host controller present in Tegra194 SoC. General comments: - Th

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-03-29 Thread Bjorn Helgaas
Hi Vidya, Wow, there's a lot of nice work here! Thanks for that! On Tue, Mar 26, 2019 at 08:43:26PM +0530, Vidya Sagar wrote: > Add support for Synopsys DesignWare core IP based PCIe host controller > present in Tegra194 SoC. General comments: - There are a few multi-line comments that don't

Re: [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-03-27 Thread Jon Hunter
On 26/03/2019 15:13, Vidya Sagar wrote: > Add support for Synopsys DesignWare core IP based PCIe host controller > present in Tegra194 SoC. > > Signed-off-by: Vidya Sagar > --- > drivers/pci/controller/dwc/Kconfig | 10 + > drivers/pci/controller/dwc/Makefile|1 + > drive

[PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support

2019-03-26 Thread Vidya Sagar
Add support for Synopsys DesignWare core IP based PCIe host controller present in Tegra194 SoC. Signed-off-by: Vidya Sagar --- drivers/pci/controller/dwc/Kconfig | 10 + drivers/pci/controller/dwc/Makefile|1 + drivers/pci/controller/dwc/pcie-tegra194.c | 1862 +