Re: [PATCH 09/10] net/macb: ethtool interface: add register dump feature

2012-09-05 Thread Ben Hutchings
On Wed, 2012-09-05 at 11:00 +0200, Nicolas Ferre wrote: > Add macb_get_regs() ethtool function and its helper function: > macb_get_regs_len(). > > Signed-off-by: Nicolas Ferre > --- > drivers/net/ethernet/cadence/macb.c | 40 > +++ > drivers/net/ethernet/cadenc

Re: [PATCH 09/10] net/macb: ethtool interface: add register dump feature

2012-09-05 Thread David Miller
From: Nicolas Ferre Date: Wed, 5 Sep 2012 11:00:54 +0200 > @@ -10,6 +10,9 @@ > #ifndef _MACB_H > #define _MACB_H > > + > +#define MACB_GREGS_LEN 32 Please don't add such extraneous empty lines. One empty line between constructs is more than enough, and anything more is visually awkward. Th

[PATCH 09/10] net/macb: ethtool interface: add register dump feature

2012-09-05 Thread Nicolas Ferre
Add macb_get_regs() ethtool function and its helper function: macb_get_regs_len(). Signed-off-by: Nicolas Ferre --- drivers/net/ethernet/cadence/macb.c | 40 +++ drivers/net/ethernet/cadence/macb.h |3 +++ 2 files changed, 43 insertions(+) diff --git a/driv