Re: [PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()

2016-11-02 Thread Masahiro Yamada
2016-10-29 8:42 GMT+09:00 Jim Davis : > On Fri, Oct 28, 2016 at 1:40 AM, SF Markus Elfring > wrote: > >> + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { > > Rather than scatter fragile magic numbers, like 10, throughout the > code, if you're hell-bent on checking for printf errors

Re: [PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()

2016-10-28 Thread Jim Davis
On Fri, Oct 28, 2016 at 1:40 AM, SF Markus Elfring wrote: > + if (printf("cmd_%s := %s\n\n", target, cmdline) < 10) { Rather than scatter fragile magic numbers, like 10, throughout the code, if you're hell-bent on checking for printf errors you could write a little wrapper function that hi

[PATCH 09/10] scripts/basic/fixdep: Complete error handling in print_cmdline()

2016-10-28 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 28 Oct 2016 09:29:59 +0200 A return value was not checked from a call of the function "printf". This issue was detected also by using the Coccinelle software. Add a bit of exception handling there. Signed-off-by: Markus Elfring --- scripts/basic/fixdep.c | 7