Re: [PATCH 09/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_control()

2014-05-18 Thread Amit Kachhap
Hi Bartlomiej, On 5/5/14, Bartlomiej Zolnierkiewicz wrote: > pdata->reference_voltage and pdata->gain are always defined > to non-zero values so remove the redundant checks from > exynos_tmu_control(). I prefer to have these checks for the same reason that new soc support should not add these same

Re: [PATCH 09/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_control()

2014-05-15 Thread Bartlomiej Zolnierkiewicz
On Thursday, May 15, 2014 11:03:08 AM Eduardo Valentin wrote: > Hello Bartlomiej, Hi, > On Mon, May 05, 2014 at 01:15:38PM +0200, Bartlomiej Zolnierkiewicz wrote: > > pdata->reference_voltage and pdata->gain are always defined > > to non-zero values so remove the redundant checks from > > exynos_

Re: [PATCH 09/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_control()

2014-05-15 Thread Eduardo Valentin
Hello Bartlomiej, On Mon, May 05, 2014 at 01:15:38PM +0200, Bartlomiej Zolnierkiewicz wrote: > pdata->reference_voltage and pdata->gain are always defined > to non-zero values so remove the redundant checks from > exynos_tmu_control(). > In all existing SoCs? Should this be considered to any up

[PATCH 09/10] thermal: exynos: remove redundant pdata checks from exynos_tmu_control()

2014-05-05 Thread Bartlomiej Zolnierkiewicz
pdata->reference_voltage and pdata->gain are always defined to non-zero values so remove the redundant checks from exynos_tmu_control(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 12 ---