Re: [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition

2014-05-14 Thread Dean Jenkins
On 20/03/14 19:30, Felipe Balbi wrote: LDISCs shouldn't call tty->ops->write() from within ->write_wakeup(). ->write_wakeup() is called with port lock taken and IRQs disabled, tty->ops->write() will try to acquire the same port lock and we will deadlock. I think the work queue should be placed

Re: [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition

2014-03-26 Thread Felipe Balbi
Hi, On Wed, Mar 26, 2014 at 10:20:15PM -0400, Peter Hurley wrote: > >>You may want to build on top of this patch split handling; > >>I noticed some of the protocol drivers are calling > >>hci_uart_tx_wakeup() from work functions already (so don't > >>need to schedule another work...) > > > >I don'

Re: [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition

2014-03-26 Thread Peter Hurley
On 03/26/2014 10:09 PM, Felipe Balbi wrote: I just noticed this patch wasn't addressed to Marcel; seems like this should go through the bluetooth tree (but not through bluetooth-next because it fixes an oops). read the archives: http://marc.info/?l=linux-bluetooth&m=139534449409583&w=2 Sorry

Re: [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition

2014-03-26 Thread Felipe Balbi
Hi, On Wed, Mar 26, 2014 at 08:47:15PM -0400, Peter Hurley wrote: > [ +to Marcel Holtmann ] > > On 03/20/2014 03:30 PM, Felipe Balbi wrote: > >LDISCs shouldn't call tty->ops->write() from within > >->write_wakeup(). > > > >->write_wakeup() is called with port lock taken and > >IRQs disabled, tty-

Re: [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition

2014-03-26 Thread Peter Hurley
[ +to Marcel Holtmann ] On 03/20/2014 03:30 PM, Felipe Balbi wrote: LDISCs shouldn't call tty->ops->write() from within ->write_wakeup(). ->write_wakeup() is called with port lock taken and IRQs disabled, tty->ops->write() will try to acquire the same port lock and we will deadlock. Reviewed-b

Re: [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition

2014-03-20 Thread Felipe Balbi
On Thu, Mar 20, 2014 at 12:40:40PM -0700, Marcel Holtmann wrote: > Hi Felipe, > > > LDISCs shouldn't call tty->ops->write() from within > > ->write_wakeup(). > > > > ->write_wakeup() is called with port lock taken and > > IRQs disabled, tty->ops->write() will try to acquire > > the same port lock

Re: [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition

2014-03-20 Thread Marcel Holtmann
Hi Felipe, > LDISCs shouldn't call tty->ops->write() from within > ->write_wakeup(). > > ->write_wakeup() is called with port lock taken and > IRQs disabled, tty->ops->write() will try to acquire > the same port lock and we will deadlock. > > Reviewed-by: Peter Hurley > Reported-by: Huang Shiji

[PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition

2014-03-20 Thread Felipe Balbi
LDISCs shouldn't call tty->ops->write() from within ->write_wakeup(). ->write_wakeup() is called with port lock taken and IRQs disabled, tty->ops->write() will try to acquire the same port lock and we will deadlock. Reviewed-by: Peter Hurley Reported-by: Huang Shijie Signed-off-by: Felipe Balbi