Re: [PATCH 09/11] vfs: factor out inode_insert5()

2018-06-12 Thread Miklos Szeredi
On Mon, Jun 11, 2018 at 05:43:55PM +0100, Al Viro wrote: > On Mon, Jun 11, 2018 at 01:32:30PM +0200, Miklos Szeredi wrote: > > > Incremental follows. I think it's cleaner to initialize i_state and > > i_sb_list > > up front (hence the use of new_inode()), but could just as well add to sb > > li

Re: [PATCH 09/11] vfs: factor out inode_insert5()

2018-06-11 Thread Al Viro
On Mon, Jun 11, 2018 at 01:32:30PM +0200, Miklos Szeredi wrote: > Incremental follows. I think it's cleaner to initialize i_state and i_sb_list > up front (hence the use of new_inode()), but could just as well add to sb list > afterwards. > --- > diff --git a/fs/inode.c b/fs/inode.c > index 0df4

Re: [PATCH 09/11] vfs: factor out inode_insert5()

2018-06-11 Thread Miklos Szeredi
On Mon, Jun 11, 2018 at 11:15:55AM +0200, Miklos Szeredi wrote: > On Sun, Jun 10, 2018 at 8:02 AM, Al Viro wrote: > > On Sun, Jun 10, 2018 at 06:49:10AM +0100, Al Viro wrote: > >> On Tue, May 29, 2018 at 04:41:41PM +0200, Miklos Szeredi wrote: > >> > From: Miklos Szeredi > >> > > >> > Split out c

Re: [PATCH 09/11] vfs: factor out inode_insert5()

2018-06-11 Thread Miklos Szeredi
On Sun, Jun 10, 2018 at 8:02 AM, Al Viro wrote: > On Sun, Jun 10, 2018 at 06:49:10AM +0100, Al Viro wrote: >> On Tue, May 29, 2018 at 04:41:41PM +0200, Miklos Szeredi wrote: >> > From: Miklos Szeredi >> > >> > Split out common helper for race free insertion of an already allocated >> > inode into

Re: [PATCH 09/11] vfs: factor out inode_insert5()

2018-06-09 Thread Al Viro
On Sun, Jun 10, 2018 at 06:49:10AM +0100, Al Viro wrote: > On Tue, May 29, 2018 at 04:41:41PM +0200, Miklos Szeredi wrote: > > From: Miklos Szeredi > > > > Split out common helper for race free insertion of an already allocated > > inode into the cache. Use this from iget5_locked() and > > inser

Re: [PATCH 09/11] vfs: factor out inode_insert5()

2018-06-09 Thread Al Viro
On Tue, May 29, 2018 at 04:41:41PM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > Split out common helper for race free insertion of an already allocated > inode into the cache. Use this from iget5_locked() and > insert_inode_locked4(). Make iget5_locked() use new_inode()/iput() instea

[PATCH 09/11] vfs: factor out inode_insert5()

2018-05-29 Thread Miklos Szeredi
From: Miklos Szeredi Split out common helper for race free insertion of an already allocated inode into the cache. Use this from iget5_locked() and insert_inode_locked4(). Make iget5_locked() use new_inode()/iput() instead of alloc_inode()/destroy_inode() directly. Also export to modules for u