Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

On 25/02/2016 10:10, Xiao Guangrong wrote: > > > On 02/25/2016 04:49 PM, Paolo Bonzini wrote: >> >> >> On 25/02/2016 08:35, Xiao Guangrong wrote: This may release the mmu_lock before committing the zapping. Is it safe? If so, we may want to see the reason in the changelog. >>> >>>

Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

On 25/02/2016 10:10, Xiao Guangrong wrote: > > > On 02/25/2016 04:49 PM, Paolo Bonzini wrote: >> >> >> On 25/02/2016 08:35, Xiao Guangrong wrote: This may release the mmu_lock before committing the zapping. Is it safe? If so, we may want to see the reason in the changelog. >>> >>>

Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

On 02/25/2016 04:49 PM, Paolo Bonzini wrote: On 25/02/2016 08:35, Xiao Guangrong wrote: This may release the mmu_lock before committing the zapping. Is it safe? If so, we may want to see the reason in the changelog. It is unsafe indeed, please do not do it. Can you explain why?

Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

On 02/25/2016 04:49 PM, Paolo Bonzini wrote: On 25/02/2016 08:35, Xiao Guangrong wrote: This may release the mmu_lock before committing the zapping. Is it safe? If so, we may want to see the reason in the changelog. It is unsafe indeed, please do not do it. Can you explain why?

Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

On 25/02/2016 08:35, Xiao Guangrong wrote: >> This may release the mmu_lock before committing the zapping. >> Is it safe? If so, we may want to see the reason in the changelog. > > It is unsafe indeed, please do not do it. Can you explain why? kvm_zap_obsolete_pages does the same. Paolo

Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

On 25/02/2016 08:35, Xiao Guangrong wrote: >> This may release the mmu_lock before committing the zapping. >> Is it safe? If so, we may want to see the reason in the changelog. > > It is unsafe indeed, please do not do it. Can you explain why? kvm_zap_obsolete_pages does the same. Paolo

Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

On 25/02/2016 03:15, Takuya Yoshikawa wrote: > On 2016/02/24 22:17, Paolo Bonzini wrote: >> Move the call to kvm_mmu_flush_or_zap outside the loop. >> >> Signed-off-by: Paolo Bonzini >> --- >> arch/x86/kvm/mmu.c | 9 ++--- >> 1 file changed, 6 insertions(+), 3

Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

On 25/02/2016 03:15, Takuya Yoshikawa wrote: > On 2016/02/24 22:17, Paolo Bonzini wrote: >> Move the call to kvm_mmu_flush_or_zap outside the loop. >> >> Signed-off-by: Paolo Bonzini >> --- >> arch/x86/kvm/mmu.c | 9 ++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> diff

Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

On 02/25/2016 10:15 AM, Takuya Yoshikawa wrote: On 2016/02/24 22:17, Paolo Bonzini wrote: Move the call to kvm_mmu_flush_or_zap outside the loop. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/mmu.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)

Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

On 02/25/2016 10:15 AM, Takuya Yoshikawa wrote: On 2016/02/24 22:17, Paolo Bonzini wrote: Move the call to kvm_mmu_flush_or_zap outside the loop. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/mmu.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

On 2016/02/24 22:17, Paolo Bonzini wrote: > Move the call to kvm_mmu_flush_or_zap outside the loop. > > Signed-off-by: Paolo Bonzini > --- > arch/x86/kvm/mmu.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c

Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

On 2016/02/24 22:17, Paolo Bonzini wrote: > Move the call to kvm_mmu_flush_or_zap outside the loop. > > Signed-off-by: Paolo Bonzini > --- > arch/x86/kvm/mmu.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index

[PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

Move the call to kvm_mmu_flush_or_zap outside the loop. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/mmu.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 725316df32ec..6d47b5c43246 100644 ---

[PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children

Move the call to kvm_mmu_flush_or_zap outside the loop. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/mmu.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 725316df32ec..6d47b5c43246 100644 --- a/arch/x86/kvm/mmu.c +++