Re: [PATCH 09/12] iomap: lift the xfs writeback code to iomap

2019-10-16 Thread Brian Foster
On Wed, Oct 16, 2019 at 09:48:36AM +0200, Christoph Hellwig wrote: > On Wed, Oct 16, 2019 at 09:07:21AM +1100, Dave Chinner wrote: ... > > > +/* > > > + * Submit the bio for an ioend. We are passed an ioend with a bio > > > attached to > > > + * it, and we submit that bio. The ioend may be used fo

Re: [PATCH 09/12] iomap: lift the xfs writeback code to iomap

2019-10-16 Thread Christoph Hellwig
On Wed, Oct 16, 2019 at 09:07:21AM +1100, Dave Chinner wrote: > > +/* > > + * We implement an immediate ioend submission policy here to avoid needing > > to > > + * chain multiple ioends and hence nest mempool allocations which can > > violate > > + * forward progress guarantees we need to provid

Re: [PATCH 09/12] iomap: lift the xfs writeback code to iomap

2019-10-16 Thread Christoph Hellwig
On Wed, Oct 16, 2019 at 09:07:21AM +1100, Dave Chinner wrote: > > + trace_iomap_releasepage(page->mapping->host, page, 0, 0); > > + > > /* > > * mm accommodates an old ext3 case where clean pages might not have had > > * the dirty bit cleared. Thus, it can send actual dirty pages to

Re: [PATCH 09/12] iomap: lift the xfs writeback code to iomap

2019-10-16 Thread Christoph Hellwig
On Tue, Oct 15, 2019 at 11:40:40AM -0700, Darrick J. Wong wrote: > > + if (unlikely(error && !quiet)) { > > + printk_ratelimited(KERN_ERR > > + "%s: writeback error on sector %llu", > > + inode->i_sb->s_id, start); > > Ugh, /this/ message. It's pret

Re: [PATCH 09/12] iomap: lift the xfs writeback code to iomap

2019-10-15 Thread Darrick J. Wong
On Wed, Oct 16, 2019 at 09:07:21AM +1100, Dave Chinner wrote: > On Tue, Oct 15, 2019 at 05:43:42PM +0200, Christoph Hellwig wrote: > > Take the xfs writeback code and move it to fs/iomap. A new structure > > with three methods is added as the abstraction from the generic writeback > > code to the

Re: [PATCH 09/12] iomap: lift the xfs writeback code to iomap

2019-10-15 Thread Dave Chinner
On Tue, Oct 15, 2019 at 05:43:42PM +0200, Christoph Hellwig wrote: > Take the xfs writeback code and move it to fs/iomap. A new structure > with three methods is added as the abstraction from the generic writeback > code to the file system. These methods are used to map blocks, submit an > ioend,

Re: [PATCH 09/12] iomap: lift the xfs writeback code to iomap

2019-10-15 Thread Darrick J. Wong
On Tue, Oct 15, 2019 at 05:43:42PM +0200, Christoph Hellwig wrote: > Take the xfs writeback code and move it to fs/iomap. A new structure > with three methods is added as the abstraction from the generic writeback > code to the file system. These methods are used to map blocks, submit an > ioend,

[PATCH 09/12] iomap: lift the xfs writeback code to iomap

2019-10-15 Thread Christoph Hellwig
Take the xfs writeback code and move it to fs/iomap. A new structure with three methods is added as the abstraction from the generic writeback code to the file system. These methods are used to map blocks, submit an ioend, and cancel a page that encountered an error before it was added to an ioen