[PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast()

2017-06-17 Thread NeilBrown
pblk_submit_read() uses bio_clone_bioset() but doesn't change the io_vec, so bio_clone_fast() is a better choice. It also uses fs_bio_set which is intended for filesystems. Using it in a device driver can deadlock. So allocate a new bioset, and and use bio_clone_fast(). Reviewed-by: Christoph

[PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast()

2017-06-17 Thread NeilBrown
pblk_submit_read() uses bio_clone_bioset() but doesn't change the io_vec, so bio_clone_fast() is a better choice. It also uses fs_bio_set which is intended for filesystems. Using it in a device driver can deadlock. So allocate a new bioset, and and use bio_clone_fast(). Reviewed-by: Christoph

Re: [PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast()

2017-05-03 Thread Javier González
> On 2 May 2017, at 23.51, NeilBrown wrote: > >> >> Hi Neil, >> >> Looks good. Thanks for fixing this. I did not know that bio_clone_bioset >> was not supposed to be used on drivers. > > Prior to my patchset, using bio_clone_bioset() wasn't wrong in drivers, > though it was a

Re: [PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast()

2017-05-03 Thread Javier González
> On 2 May 2017, at 23.51, NeilBrown wrote: > >> >> Hi Neil, >> >> Looks good. Thanks for fixing this. I did not know that bio_clone_bioset >> was not supposed to be used on drivers. > > Prior to my patchset, using bio_clone_bioset() wasn't wrong in drivers, > though it was a waste when

Re: [PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast()

2017-05-02 Thread NeilBrown
On Tue, May 02 2017, Javier González wrote: >> On 2 May 2017, at 05.42, NeilBrown wrote: >> >> pblk_submit_read() uses bio_clone_bioset() but doesn't change the >> io_vec, so bio_clone_fast() is a better choice. >> >> It also uses fs_bio_set which is intended for filesystems.

Re: [PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast()

2017-05-02 Thread NeilBrown
On Tue, May 02 2017, Javier González wrote: >> On 2 May 2017, at 05.42, NeilBrown wrote: >> >> pblk_submit_read() uses bio_clone_bioset() but doesn't change the >> io_vec, so bio_clone_fast() is a better choice. >> >> It also uses fs_bio_set which is intended for filesystems. Using it >> in a

Re: [PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast()

2017-05-02 Thread Javier González
> On 2 May 2017, at 05.42, NeilBrown wrote: > > pblk_submit_read() uses bio_clone_bioset() but doesn't change the > io_vec, so bio_clone_fast() is a better choice. > > It also uses fs_bio_set which is intended for filesystems. Using it > in a device driver can deadlock. > So

Re: [PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast()

2017-05-02 Thread Javier González
> On 2 May 2017, at 05.42, NeilBrown wrote: > > pblk_submit_read() uses bio_clone_bioset() but doesn't change the > io_vec, so bio_clone_fast() is a better choice. > > It also uses fs_bio_set which is intended for filesystems. Using it > in a device driver can deadlock. > So allocate a new

Re: [PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast()

2017-05-02 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast()

2017-05-02 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

[PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast()

2017-05-01 Thread NeilBrown
pblk_submit_read() uses bio_clone_bioset() but doesn't change the io_vec, so bio_clone_fast() is a better choice. It also uses fs_bio_set which is intended for filesystems. Using it in a device driver can deadlock. So allocate a new bioset, and and use bio_clone_fast(). Signed-off-by: NeilBrown

[PATCH 09/13] lightnvm/pblk-read: use bio_clone_fast()

2017-05-01 Thread NeilBrown
pblk_submit_read() uses bio_clone_bioset() but doesn't change the io_vec, so bio_clone_fast() is a better choice. It also uses fs_bio_set which is intended for filesystems. Using it in a device driver can deadlock. So allocate a new bioset, and and use bio_clone_fast(). Signed-off-by: NeilBrown