Re: [PATCH 09/14] mm: use compaction feedback for thp backoff conditions

2016-04-29 Thread Michal Hocko
On Fri 29-04-16 11:16:44, Vlastimil Babka wrote: > On 04/28/2016 02:35 PM, Michal Hocko wrote: [...] > >My main point was to simplify the code and get rid of as much compaction > >specific hacks as possible. We might very well drop this later on but it > >would be at least less code to grasp

Re: [PATCH 09/14] mm: use compaction feedback for thp backoff conditions

2016-04-29 Thread Michal Hocko
On Fri 29-04-16 11:16:44, Vlastimil Babka wrote: > On 04/28/2016 02:35 PM, Michal Hocko wrote: [...] > >My main point was to simplify the code and get rid of as much compaction > >specific hacks as possible. We might very well drop this later on but it > >would be at least less code to grasp

Re: [PATCH 09/14] mm: use compaction feedback for thp backoff conditions

2016-04-29 Thread Vlastimil Babka
On 04/28/2016 02:35 PM, Michal Hocko wrote: On Thu 28-04-16 10:53:18, Vlastimil Babka wrote: On 04/20/2016 09:47 PM, Michal Hocko wrote: From: Michal Hocko THP requests skip the direct reclaim if the compaction is either deferred or contended to reduce stalls which wouldn't

Re: [PATCH 09/14] mm: use compaction feedback for thp backoff conditions

2016-04-29 Thread Vlastimil Babka
On 04/28/2016 02:35 PM, Michal Hocko wrote: On Thu 28-04-16 10:53:18, Vlastimil Babka wrote: On 04/20/2016 09:47 PM, Michal Hocko wrote: From: Michal Hocko THP requests skip the direct reclaim if the compaction is either deferred or contended to reduce stalls which wouldn't help the

Re: [PATCH 09/14] mm: use compaction feedback for thp backoff conditions

2016-04-28 Thread Michal Hocko
On Thu 28-04-16 10:53:18, Vlastimil Babka wrote: > On 04/20/2016 09:47 PM, Michal Hocko wrote: > >From: Michal Hocko > > > >THP requests skip the direct reclaim if the compaction is either > >deferred or contended to reduce stalls which wouldn't help the > >allocation success

Re: [PATCH 09/14] mm: use compaction feedback for thp backoff conditions

2016-04-28 Thread Michal Hocko
On Thu 28-04-16 10:53:18, Vlastimil Babka wrote: > On 04/20/2016 09:47 PM, Michal Hocko wrote: > >From: Michal Hocko > > > >THP requests skip the direct reclaim if the compaction is either > >deferred or contended to reduce stalls which wouldn't help the > >allocation success anyway. These checks

Re: [PATCH 09/14] mm: use compaction feedback for thp backoff conditions

2016-04-28 Thread Vlastimil Babka
On 04/20/2016 09:47 PM, Michal Hocko wrote: From: Michal Hocko THP requests skip the direct reclaim if the compaction is either deferred or contended to reduce stalls which wouldn't help the allocation success anyway. These checks are ignoring other potential feedback modes

Re: [PATCH 09/14] mm: use compaction feedback for thp backoff conditions

2016-04-28 Thread Vlastimil Babka
On 04/20/2016 09:47 PM, Michal Hocko wrote: From: Michal Hocko THP requests skip the direct reclaim if the compaction is either deferred or contended to reduce stalls which wouldn't help the allocation success anyway. These checks are ignoring other potential feedback modes which we have

Re: [PATCH 09/14] mm: use compaction feedback for thp backoff conditions

2016-04-21 Thread Hillf Danton
> > From: Michal Hocko > > THP requests skip the direct reclaim if the compaction is either > deferred or contended to reduce stalls which wouldn't help the > allocation success anyway. These checks are ignoring other potential > feedback modes which we have available now. > >

Re: [PATCH 09/14] mm: use compaction feedback for thp backoff conditions

2016-04-21 Thread Hillf Danton
> > From: Michal Hocko > > THP requests skip the direct reclaim if the compaction is either > deferred or contended to reduce stalls which wouldn't help the > allocation success anyway. These checks are ignoring other potential > feedback modes which we have available now. > > It clearly

[PATCH 09/14] mm: use compaction feedback for thp backoff conditions

2016-04-20 Thread Michal Hocko
From: Michal Hocko THP requests skip the direct reclaim if the compaction is either deferred or contended to reduce stalls which wouldn't help the allocation success anyway. These checks are ignoring other potential feedback modes which we have available now. It clearly doesn't

[PATCH 09/14] mm: use compaction feedback for thp backoff conditions

2016-04-20 Thread Michal Hocko
From: Michal Hocko THP requests skip the direct reclaim if the compaction is either deferred or contended to reduce stalls which wouldn't help the allocation success anyway. These checks are ignoring other potential feedback modes which we have available now. It clearly doesn't make much sense