Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread Martin K. Petersen
> "James" == James Bottomley writes: James> I'm intrigued by this: how do you get the extra space, since I James> heard all the drive vendors were adamant that 520 was it for the James> current manufacturing processes. Well, you've been able to get 528-byte sector drives for a long time. The

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread James Bottomley
On Mon, 2014-01-13 at 15:19 -0500, Martin K. Petersen wrote: > > "nab" == Nicholas A Bellinger writes: > > >> What proposed 16 byte scheme? The only DIF proposals I know for > >> SBC-4 are 13-185R0 and 12-369R0 and that's a couple of new algorithms > >> and types because we cannot change the

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread Martin K. Petersen
> "nab" == Nicholas A Bellinger writes: >> What proposed 16 byte scheme? The only DIF proposals I know for >> SBC-4 are 13-185R0 and 12-369R0 and that's a couple of new algorithms >> and types because we cannot change the 8 byte PI. nab> Then I'm probably getting the SBC version wrong.. It

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread James Bottomley
On Mon, 2014-01-13 at 11:27 -0800, Nicholas A. Bellinger wrote: > On Mon, 2014-01-13 at 10:52 -0800, James Bottomley wrote: > > On Mon, 2014-01-13 at 10:30 -0800, Nicholas A. Bellinger wrote: > > > Hey MKP, > > > > > > On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: > > > > > "nab

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread Nicholas A. Bellinger
On Mon, 2014-01-13 at 10:52 -0800, James Bottomley wrote: > On Mon, 2014-01-13 at 10:30 -0800, Nicholas A. Bellinger wrote: > > Hey MKP, > > > > On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: > > > > "nab" == Nicholas A Bellinger writes: > > > > > > nab> This patch adds support

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread James Bottomley
On Mon, 2014-01-13 at 10:30 -0800, Nicholas A. Bellinger wrote: > Hey MKP, > > On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: > > > "nab" == Nicholas A Bellinger writes: > > > > nab> This patch adds support for exposing DIF protection device > > nab> attributes via configfs. T

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread Nicholas A. Bellinger
Hey MKP, On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: > > "nab" == Nicholas A Bellinger writes: > > nab> This patch adds support for exposing DIF protection device > nab> attributes via configfs. This includes: > > nab>pi_prot_type: Protection Type (0, 1, 3 currently su

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-12 Thread Sagi Grimberg
On 1/12/2014 2:43 PM, Martin K. Petersen wrote: "Sagi" == Sagi Grimberg writes: The IP checksum is only supported by DIX between OS and initiator, not by the target. I guess we could signal to the initiator via a vendor-private VPD that IP checksum is supported directly. But now what we have ha

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-12 Thread Martin K. Petersen
> "Sagi" == Sagi Grimberg writes: >> The IP checksum is only supported by DIX between OS and initiator, >> not by the target. I guess we could signal to the initiator via a >> vendor-private VPD that IP checksum is supported directly. But now >> what we have hardware-accelerated T10 CRC I don

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-12 Thread Sagi Grimberg
nab> This patch adds support for exposing DIF protection device nab> attributes via configfs. This includes: nab>pi_prot_type: Protection Type (0, 1, 3 currently support) nab>pi_prot_version: Protection Version (DIF v1 currently supported) What's DIF v2? nab>pi_guard_type: Guard

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-12 Thread Sagi Grimberg
On 1/10/2014 9:00 AM, Nicholas A. Bellinger wrote: On Thu, 2014-01-09 at 13:01 +0200, Sagi Grimberg wrote: On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch adds support for exposing DIF protection device attributes via configfs. This includes: pi_p

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-10 Thread Martin K. Petersen
> "nab" == Nicholas A Bellinger writes: nab> This patch adds support for exposing DIF protection device nab> attributes via configfs. This includes: nab>pi_prot_type: Protection Type (0, 1, 3 currently support) nab>pi_prot_version: Protection Version (DIF v1 currently supported) Wh

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-09 Thread Nicholas A. Bellinger
On Thu, 2014-01-09 at 13:01 +0200, Sagi Grimberg wrote: > On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds support for exposing DIF protection device > > attributes via configfs. This includes: > > > > pi_prot_type: Protection Type (0, 1,

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-09 Thread Sagi Grimberg
On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch adds support for exposing DIF protection device attributes via configfs. This includes: pi_prot_type: Protection Type (0, 1, 3 currently support) pi_prot_version: Protection Version (DIF v1 currentl

[PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-08 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support for exposing DIF protection device attributes via configfs. This includes: pi_prot_type: Protection Type (0, 1, 3 currently support) pi_prot_version: Protection Version (DIF v1 currently supported) pi_guard_type: Guard Type (1=DIF CRC, 2