Re: [PATCH 09/15] x86/alternatives: Use C int3 selftest but disable KASAN

2021-04-20 Thread Peter Zijlstra
On Mon, Apr 19, 2021 at 08:26:36AM -0700, Sami Tolvanen wrote: > On Sat, Apr 17, 2021 at 4:37 AM Peter Zijlstra wrote: > > The problem is that the call-site does not respect the regular calling > > convention, so calling a regular C function is just asking for trouble, > > which is why it ended u

Re: [PATCH 09/15] x86/alternatives: Use C int3 selftest but disable KASAN

2021-04-19 Thread Sami Tolvanen
On Sat, Apr 17, 2021 at 4:37 AM Peter Zijlstra wrote: > > On Fri, Apr 16, 2021 at 01:38:38PM -0700, Sami Tolvanen wrote: > > From: Kees Cook > > > > Instead of using inline asm for the int3 selftest (which confuses the > > Clang's ThinLTO pass), this restores the C function but disables KASAN > >

Re: [PATCH 09/15] x86/alternatives: Use C int3 selftest but disable KASAN

2021-04-17 Thread Peter Zijlstra
On Fri, Apr 16, 2021 at 01:38:38PM -0700, Sami Tolvanen wrote: > From: Kees Cook > > Instead of using inline asm for the int3 selftest (which confuses the > Clang's ThinLTO pass), this restores the C function but disables KASAN > (and tracing for good measure) to keep the things simple and avoid

[PATCH 09/15] x86/alternatives: Use C int3 selftest but disable KASAN

2021-04-16 Thread Sami Tolvanen
From: Kees Cook Instead of using inline asm for the int3 selftest (which confuses the Clang's ThinLTO pass), this restores the C function but disables KASAN (and tracing for good measure) to keep the things simple and avoid unexpected side-effects. This attempts to keep the fix from commit ecc606