Re: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check

2015-10-08 Thread Yaowei Bai
On Thu, Oct 01, 2015 at 10:49:41PM +0200, Mikulas Patocka wrote: > > > On Wed, 30 Sep 2015, Yaowei Bai wrote: > > > On Tue, Sep 29, 2015 at 05:03:24PM +0200, Mikulas Patocka wrote: > > > Hi > > > > > > I suppose that you should remove the function new_valid_dev at all. > > > > Yes, i thought a

Re: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check

2015-10-01 Thread Mikulas Patocka
On Wed, 30 Sep 2015, Yaowei Bai wrote: > On Tue, Sep 29, 2015 at 05:03:24PM +0200, Mikulas Patocka wrote: > > Hi > > > > I suppose that you should remove the function new_valid_dev at all. > > Yes, i thought about that, but actually there's still a user of > new_valid_dev in fs/stat.c: > >

Re: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check

2015-09-30 Thread Yaowei Bai
On Tue, Sep 29, 2015 at 05:03:24PM +0200, Mikulas Patocka wrote: > Hi > > I suppose that you should remove the function new_valid_dev at all. Yes, i thought about that, but actually there's still a user of new_valid_dev in fs/stat.c: #define valid_dev(x) choose_32_64(old_valid_dev,new_v

Re: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check

2015-09-29 Thread Mikulas Patocka
Hi I suppose that you should remove the function new_valid_dev at all. Mikulas On Mon, 28 Sep 2015, Yaowei Bai wrote: > As new_valid_dev always returns 1, so !new_valid_dev check is not > needed, remove it. > > Signed-off-by: Yaowei Bai > --- > fs/hpfs/namei.c | 2 -- > 1 file changed, 2 de

[PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check

2015-09-28 Thread Yaowei Bai
As new_valid_dev always returns 1, so !new_valid_dev check is not needed, remove it. Signed-off-by: Yaowei Bai --- fs/hpfs/namei.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/hpfs/namei.c b/fs/hpfs/namei.c index 9e92c9c..ae4d5a1 100644 --- a/fs/hpfs/namei.c +++ b/fs/hpfs/namei.c @@ -