2016-01-05 13:29 GMT-03:00 Alan Stern :
> On Tue, 5 Jan 2016, Joe Perches wrote:
>
>> On Tue, 2016-01-05 at 11:06 -0500, Alan Stern wrote:
>> > Trying to come up with hard-and-fast rules for this sort of thing is
>> > pretty hopeless. Even "Maximize readability" doesn't work too well,
>> > because
On Tue, 5 Jan 2016, Joe Perches wrote:
> On Tue, 2016-01-05 at 11:06 -0500, Alan Stern wrote:
> > Trying to come up with hard-and-fast rules for this sort of thing is�
> > pretty hopeless.� Even "Maximize readability" doesn't work too well,�
> > because different people find different things most
On Tue, 2016-01-05 at 11:06 -0500, Alan Stern wrote:
> Trying to come up with hard-and-fast rules for this sort of thing is
> pretty hopeless. Even "Maximize readability" doesn't work too well,
> because different people find different things most readable.
Readability is mostly habituation.
A
On Tue, 5 Jan 2016, Joe Perches wrote:
> On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
> > On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
> >
> > > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd
> > > >> *ehci, __hc32 token)
> > > >>�� return '/';
> > > >>� }
> > > >
2016-01-05 12:27 GMT-03:00 Geyslan G. Bem :
> 2016-01-05 12:23 GMT-03:00 Joe Perches :
>> On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
>>> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>>>
>>> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd
>>> > >> *ehci, __hc32 token)
2016-01-05 12:23 GMT-03:00 Joe Perches :
> On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
>> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>>
>> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd
>> > >> *ehci, __hc32 token)
>> > >> return '/';
>> > >> }
>> > >>
>> >
On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd
> > >> *ehci, __hc32 token)
> > >> return '/';
> > >> }
> > >>
> > >> -static void qh_lines(
> > >> - struct ehci
On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct
> ehci_hcd *ehci, __hc32 token)
> > >> return '/';
> > >> }
> > >>
> > >> -static void qh_lines(
> > >> - struct ehci_hcd *
On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
> >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd *ehci,
> >> __hc32 token)
> >> return '/';
> >> }
> >>
> >> -static void qh_lines(
> >> - struct ehci_hcd *ehci,
> >> - struct ehci_qh *qh,
> >> - char **nextp,
> >
2016-01-04 18:00 GMT-03:00 Alan Stern :
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
>> Functions must have the opening brace at the beginning of the next line
>> and body conforming indentation.
>
> This isn't necessary if the function is an empty static inline void
> routine.
Ok. It's more relat
On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
> Functions must have the opening brace at the beginning of the next line
> and body conforming indentation.
This isn't necessary if the function is an empty static inline void
routine.
Alan Stern
> This patch also reduces qh_lines() header definition
Functions must have the opening brace at the beginning of the next line
and body conforming indentation.
This patch also reduces qh_lines() header definition to two lines.
Signed-off-by: Geyslan G. Bem
---
drivers/usb/host/ehci-dbg.c | 44 +---
1 file cha
12 matches
Mail list logo
