Re: [PATCH 09/18] tracing: Add indexing of arguments for function based events

2018-02-08 Thread Steven Rostedt
On Fri, 9 Feb 2018 08:56:15 +0900 Namhyung Kim wrote: > On Thu, Feb 08, 2018 at 10:43:43AM -0500, Steven Rostedt wrote: > > On Thu, 8 Feb 2018 19:59:24 +0900 > > Namhyung Kim wrote: > > > > > > @@ -347,6 +361,8 @@ static long long get_arg(struct func_arg *arg, > > > > unsigned long val) > >

Re: [PATCH 09/18] tracing: Add indexing of arguments for function based events

2018-02-08 Thread Namhyung Kim
On Thu, Feb 08, 2018 at 10:43:43AM -0500, Steven Rostedt wrote: > On Thu, 8 Feb 2018 19:59:24 +0900 > Namhyung Kim wrote: > > > > @@ -347,6 +361,8 @@ static long long get_arg(struct func_arg *arg, > > > unsigned long val) > > > char buf[8]; > > > int ret; > > > > > > + val += arg->index; >

Re: [PATCH 09/18] tracing: Add indexing of arguments for function based events

2018-02-08 Thread Steven Rostedt
On Thu, 8 Feb 2018 19:59:24 +0900 Namhyung Kim wrote: > > @@ -347,6 +361,8 @@ static long long get_arg(struct func_arg *arg, unsigned > > long val) > > char buf[8]; > > int ret; > > > > + val += arg->index; > > + > > if (!arg->indirect) > > return val; > > So this

Re: [PATCH 09/18] tracing: Add indexing of arguments for function based events

2018-02-08 Thread Namhyung Kim
On Fri, Feb 02, 2018 at 06:05:07PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Currently reading of 8 byte words can only happen 8 bytes aligned from the > argument. But there may be cases that they are 4 bytes aligned. To make the > capturing of arguments more flexible, ad

[PATCH 09/18] tracing: Add indexing of arguments for function based events

2018-02-02 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Currently reading of 8 byte words can only happen 8 bytes aligned from the argument. But there may be cases that they are 4 bytes aligned. To make the capturing of arguments more flexible, add a plus '+' operator that can index the variable at arbitrary indexes to