Re: [PATCH 09/20] regmap: _regmap_raw_write fix for busses without write()

2015-08-14 Thread Mark Brown
On Wed, Aug 12, 2015 at 03:05:18PM +0200, Markus Pargmann wrote: > On Wed, Aug 12, 2015 at 01:34:06PM +0100, Mark Brown wrote: > > > Yes right. On the other hand if bus->read() and bus->write() was not set > > > in the init method (before this patch series) no formatting functions at > > > all wer

Re: [PATCH 09/20] regmap: _regmap_raw_write fix for busses without write()

2015-08-12 Thread Markus Pargmann
On Wed, Aug 12, 2015 at 01:34:06PM +0100, Mark Brown wrote: > On Wed, Aug 12, 2015 at 02:20:11PM +0200, Markus Pargmann wrote: > > On Wed, Aug 12, 2015 at 12:20:35PM +0100, Mark Brown wrote: > > > On Wed, Aug 12, 2015 at 12:12:34PM +0200, Markus Pargmann wrote: > > > > > > > @@ -1229,6 +1229,11 @@

Re: [PATCH 09/20] regmap: _regmap_raw_write fix for busses without write()

2015-08-12 Thread Mark Brown
On Wed, Aug 12, 2015 at 02:20:11PM +0200, Markus Pargmann wrote: > On Wed, Aug 12, 2015 at 12:20:35PM +0100, Mark Brown wrote: > > On Wed, Aug 12, 2015 at 12:12:34PM +0200, Markus Pargmann wrote: > > > > > @@ -1229,6 +1229,11 @@ int _regmap_raw_write(struct regmap *map, unsigned > > > int reg, >

Re: [PATCH 09/20] regmap: _regmap_raw_write fix for busses without write()

2015-08-12 Thread Markus Pargmann
On Wed, Aug 12, 2015 at 12:20:35PM +0100, Mark Brown wrote: > On Wed, Aug 12, 2015 at 12:12:34PM +0200, Markus Pargmann wrote: > > > @@ -1229,6 +1229,11 @@ int _regmap_raw_write(struct regmap *map, unsigned > > int reg, > > } > > } > > > > + if (!map->bus->write && val_len ==

Re: [PATCH 09/20] regmap: _regmap_raw_write fix for busses without write()

2015-08-12 Thread Mark Brown
On Wed, Aug 12, 2015 at 12:12:34PM +0200, Markus Pargmann wrote: > @@ -1229,6 +1229,11 @@ int _regmap_raw_write(struct regmap *map, unsigned int > reg, > } > } > > + if (!map->bus->write && val_len == map->format.val_bytes) { > + ret = _regmap_bus_reg_write(m

[PATCH 09/20] regmap: _regmap_raw_write fix for busses without write()

2015-08-12 Thread Markus Pargmann
Some busses don't have a write() function defined. However we can use reg_write() in special cases. This patch adds support for reg_write() and throws errors if it was unsuccessful. Signed-off-by: Markus Pargmann --- drivers/base/regmap/regmap.c | 9 +++-- 1 file changed, 7 insertions(+), 2