Re: [PATCH 09/22] Input: apanel - switch to using polled mode of input devices

2019-10-22 Thread Sven Van Asbroeck
On Mon, Oct 21, 2019 at 5:27 PM Dmitry Torokhov wrote: > > > > +static const struct i2c_device_id apanel_id[] = { > > > + { "fujitsu_apanel", 0 }, > > > > If the driver_data field of i2c_device_id is unused, would it > > be better to match via apanel_driver.driver.of_match_table ? > > This i

Re: [PATCH 09/22] Input: apanel - switch to using polled mode of input devices

2019-10-21 Thread Dmitry Torokhov
Hi Sven, On Mon, Oct 21, 2019 at 04:05:40PM -0400, Sven Van Asbroeck wrote: > Hi Dmitry, a few minor nags below, inline. Thanks for taking a look. > > On Thu, Oct 17, 2019 at 4:42 PM Dmitry Torokhov > wrote: > > > > We have added polled mode to the normal input devices with the intent of > > r

Re: [PATCH 09/22] Input: apanel - switch to using polled mode of input devices

2019-10-21 Thread Sven Van Asbroeck
Hi Dmitry, a few minor nags below, inline. On Thu, Oct 17, 2019 at 4:42 PM Dmitry Torokhov wrote: > > We have added polled mode to the normal input devices with the intent of > retiring input_polled_dev. This converts apanel driver to use the polling > mode of standard input devices and removes d

[PATCH 09/22] Input: apanel - switch to using polled mode of input devices

2019-10-17 Thread Dmitry Torokhov
We have added polled mode to the normal input devices with the intent of retiring input_polled_dev. This converts apanel driver to use the polling mode of standard input devices and removes dependency on INPUT_POLLDEV. While at it, let's convert the driver to use devm. Signed-off-by: Dmitry Torok