Re: [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention

2016-03-14 Thread Hannes Reinecke
On 03/15/2016 04:19 AM, Finn Thain wrote: > > On Mon, 14 Mar 2016, Hannes Reinecke wrote: > >>> @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S >>> NCR5380_read(RESET_PARITY_INTERRUPT_REG); >>> *data = d + c; >>> *count = 0; >>> - *phase = NCR5380_read(STATUS_REG) & P

Re: [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention

2016-03-14 Thread Finn Thain
On Mon, 14 Mar 2016, Hannes Reinecke wrote: > > @@ -1555,8 +1555,7 @@ static int NCR5380_transfer_dma(struct S > > NCR5380_read(RESET_PARITY_INTERRUPT_REG); > > *data = d + c; > > *count = 0; > > - *phase = NCR5380_read(STATUS_REG) & PHASE_MASK; > > - return foo; > > + return re

Re: [PATCH 09/22] ncr5380: Adopt uniform DMA setup convention

2016-03-14 Thread Hannes Reinecke
On 03/14/2016 05:27 AM, Finn Thain wrote: > Standardize the DMA setup hooks so that the DMA implementation in > atari_NCR5380.c can be reconciled with pseudo DMA implementation in > NCR5380.c. > > Calls to NCR5380_dma_recv_setup() and NCR5380_dma_send_setup() return > a negative value on failure,

[PATCH 09/22] ncr5380: Adopt uniform DMA setup convention

2016-03-13 Thread Finn Thain
Standardize the DMA setup hooks so that the DMA implementation in atari_NCR5380.c can be reconciled with pseudo DMA implementation in NCR5380.c. Calls to NCR5380_dma_recv_setup() and NCR5380_dma_send_setup() return a negative value on failure, zero on PDMA transfer success and a positive byte coun