Re: [PATCH 09/30] r/o bind mounts: drop write during emergency remount

2008-02-23 Thread Al Viro
On Mon, Feb 18, 2008 at 05:29:15PM +0100, Miklos Szeredi wrote: > > file_list_lock(); > > list_for_each_entry(f, &sb->s_files, f_u.fu_list) { > > - if (S_ISREG(f->f_path.dentry->d_inode->i_mode) && file_count(f)) > > - f->f_mode &= ~FMODE_WRITE; > > + s

Re: [PATCH 09/30] r/o bind mounts: drop write during emergency remount

2008-02-18 Thread Miklos Szeredi
> The emergency remount code forcibly removes FMODE_WRITE from > filps. The r/o bind mount code notices that this was done > without a proper mnt_drop_write() and properly gives a > warning. > > This patch does a mnt_drop_write() to keep everything > balanced. > > Acked-by: Al Viro <[EMAIL

[PATCH 09/30] r/o bind mounts: drop write during emergency remount

2008-02-15 Thread Dave Hansen
The emergency remount code forcibly removes FMODE_WRITE from filps. The r/o bind mount code notices that this was done without a proper mnt_drop_write() and properly gives a warning. This patch does a mnt_drop_write() to keep everything balanced. Acked-by: Al Viro <[EMAIL PROTECTED]> Si

[RFC][PATCH 09/30] r/o bind mounts: drop write during emergency remount

2008-02-08 Thread Dave Hansen
The emergency remount code forcibly removes FMODE_WRITE from filps. The r/o bind mount code notices that this was done without a proper mnt_drop_write() and properly gives a warning. This patch does a mnt_drop_write() to keep everything balanced. Signed-off-by: Dave Hansen <[EMAIL PROTE