Re: [PATCH 09/32] Unionfs: cache-coherency - dentries

2007-09-03 Thread Jan Engelhardt
On Sep 3 2007 10:08, Josef 'Jeff' Sipek wrote: >> >+int is_newer_lower(const struct dentry *dentry) >> >> Could use bool and true/false as return value. > >I remember that way back when there was a discussion about the bool type. >What how did that end? Is bool preferred? Well if there were

Re: [PATCH 09/32] Unionfs: cache-coherency - dentries

2007-09-03 Thread Josef 'Jeff' Sipek
On Mon, Sep 03, 2007 at 08:52:17AM +0200, Jan Engelhardt wrote: > > On Sep 2 2007 22:20, Josef 'Jeff' Sipek wrote: > >@@ -184,10 +183,92 @@ out: > > } > > > > /* > >+ * Determine if the lower inode objects have changed from below the unionfs > >+ * inode. Return 1 if changed, 0 otherwise. > >+

Re: [PATCH 09/32] Unionfs: cache-coherency - dentries

2007-09-03 Thread Jan Engelhardt
On Sep 2 2007 22:20, Josef 'Jeff' Sipek wrote: >@@ -184,10 +183,92 @@ out: > } > > /* >+ * Determine if the lower inode objects have changed from below the unionfs >+ * inode. Return 1 if changed, 0 otherwise. >+ */ >+int is_newer_lower(const struct dentry *dentry) Could use bool and

Re: [PATCH 09/32] Unionfs: cache-coherency - dentries

2007-09-03 Thread Jan Engelhardt
On Sep 2 2007 22:20, Josef 'Jeff' Sipek wrote: @@ -184,10 +183,92 @@ out: } /* + * Determine if the lower inode objects have changed from below the unionfs + * inode. Return 1 if changed, 0 otherwise. + */ +int is_newer_lower(const struct dentry *dentry) Could use bool and true/false as

Re: [PATCH 09/32] Unionfs: cache-coherency - dentries

2007-09-03 Thread Josef 'Jeff' Sipek
On Mon, Sep 03, 2007 at 08:52:17AM +0200, Jan Engelhardt wrote: On Sep 2 2007 22:20, Josef 'Jeff' Sipek wrote: @@ -184,10 +183,92 @@ out: } /* + * Determine if the lower inode objects have changed from below the unionfs + * inode. Return 1 if changed, 0 otherwise. + */ +int

Re: [PATCH 09/32] Unionfs: cache-coherency - dentries

2007-09-03 Thread Jan Engelhardt
On Sep 3 2007 10:08, Josef 'Jeff' Sipek wrote: +int is_newer_lower(const struct dentry *dentry) Could use bool and true/false as return value. I remember that way back when there was a discussion about the bool type. What how did that end? Is bool preferred? Well if there were objections,

[PATCH 09/32] Unionfs: cache-coherency - dentries

2007-09-02 Thread Josef 'Jeff' Sipek
From: Erez Zadok <[EMAIL PROTECTED]> Utility functions to check if lower dentries/inodes are newer than upper ones, and purging cached data if lower objects are newer. Also passed flag to our d_revalidate_chain, to tell it if the caller may be writing data or just reading it. [jsipek: changed

[PATCH 09/32] Unionfs: cache-coherency - dentries

2007-09-02 Thread Josef 'Jeff' Sipek
From: Erez Zadok [EMAIL PROTECTED] Utility functions to check if lower dentries/inodes are newer than upper ones, and purging cached data if lower objects are newer. Also passed flag to our d_revalidate_chain, to tell it if the caller may be writing data or just reading it. [jsipek: changed