Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-11-02 Thread Ming Lei
On Wed, Nov 2, 2016 at 10:24 PM, Mike Snitzer wrote: > On Wed, Nov 02 2016 at 3:56am -0400, > Ming Lei wrote: > >> On Wed, Nov 2, 2016 at 11:09 AM, Kent Overstreet >> wrote: >> > On Mon, Oct 31, 2016 at 08:29:01AM -0700,

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-11-02 Thread Ming Lei
On Wed, Nov 2, 2016 at 10:24 PM, Mike Snitzer wrote: > On Wed, Nov 02 2016 at 3:56am -0400, > Ming Lei wrote: > >> On Wed, Nov 2, 2016 at 11:09 AM, Kent Overstreet >> wrote: >> > On Mon, Oct 31, 2016 at 08:29:01AM -0700, Christoph Hellwig wrote: >> >> On Sat, Oct 29, 2016 at 04:08:08PM +0800,

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-11-02 Thread Mike Snitzer
On Wed, Nov 02 2016 at 3:56am -0400, Ming Lei wrote: > On Wed, Nov 2, 2016 at 11:09 AM, Kent Overstreet > wrote: > > On Mon, Oct 31, 2016 at 08:29:01AM -0700, Christoph Hellwig wrote: > >> On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-11-02 Thread Mike Snitzer
On Wed, Nov 02 2016 at 3:56am -0400, Ming Lei wrote: > On Wed, Nov 2, 2016 at 11:09 AM, Kent Overstreet > wrote: > > On Mon, Oct 31, 2016 at 08:29:01AM -0700, Christoph Hellwig wrote: > >> On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei wrote: > >> > Avoid to access .bi_vcnt directly,

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-11-02 Thread Ming Lei
On Wed, Nov 2, 2016 at 11:09 AM, Kent Overstreet wrote: > On Mon, Oct 31, 2016 at 08:29:01AM -0700, Christoph Hellwig wrote: >> On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei wrote: >> > Avoid to access .bi_vcnt directly, because it may be not what >> > the driver

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-11-02 Thread Ming Lei
On Wed, Nov 2, 2016 at 11:09 AM, Kent Overstreet wrote: > On Mon, Oct 31, 2016 at 08:29:01AM -0700, Christoph Hellwig wrote: >> On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei wrote: >> > Avoid to access .bi_vcnt directly, because it may be not what >> > the driver expected any more after

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-11-01 Thread Kent Overstreet
On Mon, Oct 31, 2016 at 08:29:01AM -0700, Christoph Hellwig wrote: > On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei wrote: > > Avoid to access .bi_vcnt directly, because it may be not what > > the driver expected any more after supporting multipage bvec. > > > > Signed-off-by: Ming Lei

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-11-01 Thread Kent Overstreet
On Mon, Oct 31, 2016 at 08:29:01AM -0700, Christoph Hellwig wrote: > On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei wrote: > > Avoid to access .bi_vcnt directly, because it may be not what > > the driver expected any more after supporting multipage bvec. > > > > Signed-off-by: Ming Lei > >

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-10-31 Thread Ming Lei
On Mon, Oct 31, 2016 at 11:29 PM, Christoph Hellwig wrote: > On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei wrote: >> Avoid to access .bi_vcnt directly, because it may be not what >> the driver expected any more after supporting multipage bvec. >> >> Signed-off-by: Ming

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-10-31 Thread Ming Lei
On Mon, Oct 31, 2016 at 11:29 PM, Christoph Hellwig wrote: > On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei wrote: >> Avoid to access .bi_vcnt directly, because it may be not what >> the driver expected any more after supporting multipage bvec. >> >> Signed-off-by: Ming Lei > > It would be

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-10-31 Thread Christoph Hellwig
On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei wrote: > Avoid to access .bi_vcnt directly, because it may be not what > the driver expected any more after supporting multipage bvec. > > Signed-off-by: Ming Lei It would be really nice to have a comment in the code why

Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-10-31 Thread Christoph Hellwig
On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei wrote: > Avoid to access .bi_vcnt directly, because it may be not what > the driver expected any more after supporting multipage bvec. > > Signed-off-by: Ming Lei It would be really nice to have a comment in the code why it's even checking for

[PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-10-29 Thread Ming Lei
Avoid to access .bi_vcnt directly, because it may be not what the driver expected any more after supporting multipage bvec. Signed-off-by: Ming Lei --- drivers/md/dm-rq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-rq.c

[PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-10-29 Thread Ming Lei
Avoid to access .bi_vcnt directly, because it may be not what the driver expected any more after supporting multipage bvec. Signed-off-by: Ming Lei --- drivers/md/dm-rq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c index