Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-18 Thread Luis Henriques
On Thu, Apr 18, 2013 at 11:27:48AM +0800, Lingzhu Xiang wrote: > On 04/17/2013 09:28 PM, Luis Henriques wrote: > > On Wed, Apr 17, 2013 at 08:13:57PM +0800, Lingzhu Xiang wrote: > >> On 04/17/2013 07:56 PM, Andy Whitcroft wrote: > >>> On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote:

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-18 Thread Luis Henriques
On Thu, Apr 18, 2013 at 11:27:48AM +0800, Lingzhu Xiang wrote: On 04/17/2013 09:28 PM, Luis Henriques wrote: On Wed, Apr 17, 2013 at 08:13:57PM +0800, Lingzhu Xiang wrote: On 04/17/2013 07:56 PM, Andy Whitcroft wrote: On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote: On

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-17 Thread Lingzhu Xiang
On 04/17/2013 09:28 PM, Luis Henriques wrote: > On Wed, Apr 17, 2013 at 08:13:57PM +0800, Lingzhu Xiang wrote: >> On 04/17/2013 07:56 PM, Andy Whitcroft wrote: >>> On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote: On 04/16/2013 06:33 PM, Luis Henriques wrote: >

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-17 Thread Luis Henriques
On Wed, Apr 17, 2013 at 08:13:57PM +0800, Lingzhu Xiang wrote: > On 04/17/2013 07:56 PM, Andy Whitcroft wrote: > >On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote: > >>On 04/16/2013 06:33 PM, Luis Henriques wrote: > >>>68d929862e29a8b52a7f2f2f86a0600423b093cd efi: be more paranoid

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-17 Thread Lingzhu Xiang
On 04/17/2013 07:56 PM, Andy Whitcroft wrote: On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote: On 04/16/2013 06:33 PM, Luis Henriques wrote: 68d929862e29a8b52a7f2f2f86a0600423b093cd efi: be more paranoid about available space when creating variables This prevents a bricking

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-17 Thread Andy Whitcroft
On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote: > On 04/16/2013 06:33 PM, Luis Henriques wrote: > >68d929862e29a8b52a7f2f2f86a0600423b093cd efi: be more paranoid about > >available space when creating variables > > This prevents a bricking issue for some Samsung devices but causes

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-17 Thread Andy Whitcroft
On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote: On 04/16/2013 06:33 PM, Luis Henriques wrote: 68d929862e29a8b52a7f2f2f86a0600423b093cd efi: be more paranoid about available space when creating variables This prevents a bricking issue for some Samsung devices but causes

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-17 Thread Lingzhu Xiang
On 04/17/2013 07:56 PM, Andy Whitcroft wrote: On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote: On 04/16/2013 06:33 PM, Luis Henriques wrote: 68d929862e29a8b52a7f2f2f86a0600423b093cd efi: be more paranoid about available space when creating variables This prevents a bricking

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-17 Thread Luis Henriques
On Wed, Apr 17, 2013 at 08:13:57PM +0800, Lingzhu Xiang wrote: On 04/17/2013 07:56 PM, Andy Whitcroft wrote: On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote: On 04/16/2013 06:33 PM, Luis Henriques wrote: 68d929862e29a8b52a7f2f2f86a0600423b093cd efi: be more paranoid about

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-17 Thread Lingzhu Xiang
On 04/17/2013 09:28 PM, Luis Henriques wrote: On Wed, Apr 17, 2013 at 08:13:57PM +0800, Lingzhu Xiang wrote: On 04/17/2013 07:56 PM, Andy Whitcroft wrote: On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote: On 04/16/2013 06:33 PM, Luis Henriques wrote:

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-16 Thread Lingzhu Xiang
On 04/16/2013 06:33 PM, Luis Henriques wrote: 68d929862e29a8b52a7f2f2f86a0600423b093cd efi: be more paranoid about available space when creating variables This prevents a bricking issue for some Samsung devices but causes regression on many other machines.

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-16 Thread Luis Henriques
; > > Garrett; Josh Boyer; Michael Schroeder; Lee, Chun-Yi; Matt Fleming > > > Subject: Re: [PATCH 097/102] efivars: explicitly calculate length of > > > VariableName > > > > > > On Wed, Apr 10, 2013 at 06:27:13PM +0800, Lingzhu Xiang wrote: > > > > On

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-16 Thread Luis Henriques
] efivars: explicitly calculate length of VariableName On Wed, Apr 10, 2013 at 06:27:13PM +0800, Lingzhu Xiang wrote: On 04/10/2013 06:45 AM, Ben Hutchings wrote: On Mon, 2013-04-08 at 10:50 +0100, Luis Henriques wrote: 3.5.7.10 -stable review patch. If anyone has any objections

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-16 Thread Lingzhu Xiang
On 04/16/2013 06:33 PM, Luis Henriques wrote: 68d929862e29a8b52a7f2f2f86a0600423b093cd efi: be more paranoid about available space when creating variables This prevents a bricking issue for some Samsung devices but causes regression on many other machines.

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-11 Thread Luis Henriques
Aguchi; linux-kernel@vger.kernel.org; > > sta...@vger.kernel.org; kernel-t...@lists.ubuntu.com; Matthew > > Garrett; Josh Boyer; Michael Schroeder; Lee, Chun-Yi; Matt Fleming > > Subject: Re: [PATCH 097/102] efivars: explicitly calculate length of > > VariableName > >

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-11 Thread Luis Henriques
...@vger.kernel.org; kernel-t...@lists.ubuntu.com; Matthew Garrett; Josh Boyer; Michael Schroeder; Lee, Chun-Yi; Matt Fleming Subject: Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName On Wed, Apr 10, 2013 at 06:27:13PM +0800, Lingzhu Xiang wrote: On 04/10/2013 06:45 AM

RE: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-10 Thread Seiji Aguchi
Matthew > Garrett; Josh Boyer; Michael Schroeder; Lee, Chun-Yi; Matt Fleming > Subject: Re: [PATCH 097/102] efivars: explicitly calculate length of > VariableName > > On Wed, Apr 10, 2013 at 06:27:13PM +0800, Lingzhu Xiang wrote: > > On 04/10/2013 06:45 AM, Ben Hutchings wrote:

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-10 Thread Luis Henriques
On Wed, Apr 10, 2013 at 06:27:13PM +0800, Lingzhu Xiang wrote: > On 04/10/2013 06:45 AM, Ben Hutchings wrote: > >On Mon, 2013-04-08 at 10:50 +0100, Luis Henriques wrote: > >>3.5.7.10 -stable review patch. If anyone has any objections, please let me > >>know. > >> > >>-- > >> >

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-10 Thread Lingzhu Xiang
On 04/10/2013 06:45 AM, Ben Hutchings wrote: On Mon, 2013-04-08 at 10:50 +0100, Luis Henriques wrote: 3.5.7.10 -stable review patch. If anyone has any objections, please let me know. -- From: Matt Fleming commit ec50bd32f1672d38ddce10fb1841cbfda89cfe9a upstream. It's not

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-10 Thread Luis Henriques
On Tue, Apr 09, 2013 at 11:45:06PM +0100, Ben Hutchings wrote: > On Mon, 2013-04-08 at 10:50 +0100, Luis Henriques wrote: > > 3.5.7.10 -stable review patch. If anyone has any objections, please let me > > know. > > > > -- > > > > From: Matt Fleming > > > > commit

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-10 Thread Luis Henriques
On Tue, Apr 09, 2013 at 11:45:06PM +0100, Ben Hutchings wrote: On Mon, 2013-04-08 at 10:50 +0100, Luis Henriques wrote: 3.5.7.10 -stable review patch. If anyone has any objections, please let me know. -- From: Matt Fleming matt.flem...@intel.com commit

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-10 Thread Lingzhu Xiang
On 04/10/2013 06:45 AM, Ben Hutchings wrote: On Mon, 2013-04-08 at 10:50 +0100, Luis Henriques wrote: 3.5.7.10 -stable review patch. If anyone has any objections, please let me know. -- From: Matt Fleming matt.flem...@intel.com commit

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-10 Thread Luis Henriques
On Wed, Apr 10, 2013 at 06:27:13PM +0800, Lingzhu Xiang wrote: On 04/10/2013 06:45 AM, Ben Hutchings wrote: On Mon, 2013-04-08 at 10:50 +0100, Luis Henriques wrote: 3.5.7.10 -stable review patch. If anyone has any objections, please let me know. -- From: Matt Fleming

RE: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-10 Thread Seiji Aguchi
; Michael Schroeder; Lee, Chun-Yi; Matt Fleming Subject: Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName On Wed, Apr 10, 2013 at 06:27:13PM +0800, Lingzhu Xiang wrote: On 04/10/2013 06:45 AM, Ben Hutchings wrote: On Mon, 2013-04-08 at 10:50 +0100, Luis Henriques

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-09 Thread Ben Hutchings
On Mon, 2013-04-08 at 10:50 +0100, Luis Henriques wrote: > 3.5.7.10 -stable review patch. If anyone has any objections, please let me > know. > > -- > > From: Matt Fleming > > commit ec50bd32f1672d38ddce10fb1841cbfda89cfe9a upstream. > > It's not wise to assume

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-09 Thread Ben Hutchings
On Mon, 2013-04-08 at 10:50 +0100, Luis Henriques wrote: 3.5.7.10 -stable review patch. If anyone has any objections, please let me know. -- From: Matt Fleming matt.flem...@intel.com commit ec50bd32f1672d38ddce10fb1841cbfda89cfe9a upstream. It's not wise to assume

[PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-08 Thread Luis Henriques
3.5.7.10 -stable review patch. If anyone has any objections, please let me know. -- From: Matt Fleming commit ec50bd32f1672d38ddce10fb1841cbfda89cfe9a upstream. It's not wise to assume VariableNameSize represents the length of VariableName, as not all firmware updates

[PATCH 097/102] efivars: explicitly calculate length of VariableName

2013-04-08 Thread Luis Henriques
3.5.7.10 -stable review patch. If anyone has any objections, please let me know. -- From: Matt Fleming matt.flem...@intel.com commit ec50bd32f1672d38ddce10fb1841cbfda89cfe9a upstream. It's not wise to assume VariableNameSize represents the length of VariableName, as not all