Re: [PATCH 1/1][NEW] crypto API: rsa algorithm module patch (kernel version 2.6.20.3)

2007-03-22 Thread Indan Zupancic
Hello Tasos, Comments below. On Wed, March 21, 2007 16:13, Tasos Parisinos wrote: > This patch changes the crypto/Kconfig crypto/Makefile and adds > crypto/rsa.c. These files add module named rsa.o (rsa.ko) built-in or as > a kernel module and offer an API to do fast modular exponentiation > and

Re: [PATCH 1/1][NEW] crypto API: rsa algorithm module patch (kernel version 2.6.20.3)

2007-03-22 Thread Randy Dunlap
On Thu, 22 Mar 2007 10:36:16 +0200 Tasos Parisinos wrote: > > Hi, > > Lots of good progress here, but still a few comments below. > > > > Needs to apply to current mainline. > > > > > What do you mean by mainline? Linus's current kernel tree, i.e., the latest git tree or git snapshot preferabl

Re: [PATCH 1/1][NEW] crypto API: rsa algorithm module patch (kernel version 2.6.20.3)

2007-03-22 Thread Tasos Parisinos
Hi, Lots of good progress here, but still a few comments below. Needs to apply to current mainline. What do you mean by mainline? Most (probably all) of these functions should also be "static" unless they are meant for use outside of this module. Which leads to the question: which fu

Re: [PATCH 1/1][NEW] crypto API: rsa algorithm module patch (kernel version 2.6.20.3)

2007-03-21 Thread Randy Dunlap
On Wed, 21 Mar 2007 12:08:58 -0400 (EDT) Robert P. J. Day wrote: > On Wed, 21 Mar 2007, Randy Dunlap wrote: > > > On Wed, 21 Mar 2007 17:13:31 +0200 (EET) Tasos Parisinos wrote: > > > > +/* > > > + * mpi_alloc - allocate an mpi > > > + * @n: pointer pointer to the allocated mpi > > > + * @limbs:

Re: [PATCH 1/1][NEW] crypto API: rsa algorithm module patch (kernel version 2.6.20.3)

2007-03-21 Thread Robert P. J. Day
On Wed, 21 Mar 2007, Randy Dunlap wrote: > On Wed, 21 Mar 2007 17:13:31 +0200 (EET) Tasos Parisinos wrote: > > +/* > > + * mpi_alloc - allocate an mpi > > + * @n: pointer pointer to the allocated mpi > > + * @limbs: number of allocated limbs (32 bit digits) > > + * > > + * The allocated mpi will

Re: [PATCH 1/1][NEW] crypto API: rsa algorithm module patch (kernel version 2.6.20.3)

2007-03-21 Thread Randy Dunlap
On Wed, 21 Mar 2007 17:13:31 +0200 (EET) Tasos Parisinos wrote: > This patch changes the crypto/Kconfig crypto/Makefile and adds > crypto/rsa.c. These files add module named rsa.o (rsa.ko) built-in or as > a kernel module and offer an API to do fast modular exponentiation > and other multi-precis

[PATCH 1/1][NEW] crypto API: rsa algorithm module patch (kernel version 2.6.20.3)

2007-03-21 Thread Tasos Parisinos
This patch changes the crypto/Kconfig crypto/Makefile and adds crypto/rsa.c. These files add module named rsa.o (rsa.ko) built-in or as a kernel module and offer an API to do fast modular exponentiation and other multi-precision arithmetics. Signed-off-by: Tasos Parisinos <[EMAIL PROTECTED]> ---