Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

2017-07-29 Thread Dan Carpenter
On Sat, Jul 29, 2017 at 11:09:23AM +0200, Marcus Wolf wrote: > Hi Greg, > > also had a very close look to this patch. Even in your reply I can't find any > problems with line wraps or other corruptions :-/ > Here are the relevant lines from Greg's email: > +++ b/drivers/staging/pi433/rf69.c >

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

2017-07-29 Thread Dan Carpenter
On Sat, Jul 29, 2017 at 11:09:23AM +0200, Marcus Wolf wrote: > Hi Greg, > > also had a very close look to this patch. Even in your reply I can't find any > problems with line wraps or other corruptions :-/ > Here are the relevant lines from Greg's email: > +++ b/drivers/staging/pi433/rf69.c >

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

2017-07-29 Thread Marcus Wolf
Hi Greg, also had a very close look to this patch. Even in your reply I can't find any problems with line wraps or other corruptions :-/ But we have alternative patches, solving these problems as well. You e.g. could use the patch [PATCH] Make functions rf69_set_bandwidth_intern and

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

2017-07-29 Thread Marcus Wolf
Hi Greg, also had a very close look to this patch. Even in your reply I can't find any problems with line wraps or other corruptions :-/ But we have alternative patches, solving these problems as well. You e.g. could use the patch [PATCH] Make functions rf69_set_bandwidth_intern and

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

2017-07-28 Thread Greg Kroah-Hartman
On Thu, Jul 20, 2017 at 01:01:46PM +0200, Wolf Entwicklungen wrote: > Declare rf69_set_dc_cut_off_frequency_intern as static since it > is used internaly only > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Marcus Wolf > > diff --git

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

2017-07-28 Thread Greg Kroah-Hartman
On Thu, Jul 20, 2017 at 01:01:46PM +0200, Wolf Entwicklungen wrote: > Declare rf69_set_dc_cut_off_frequency_intern as static since it > is used internaly only > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Marcus Wolf > > diff --git a/drivers/staging/pi433/rf69.c

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

2017-07-20 Thread Marcus Wolf
Hi Colin, mine is an aditional patch for an other function, that's pretty similar to the one, you improoved. So we need both patches, yours and mine! Cheers, Marcus > Colin Ian King hat am 20. Juli 2017 um 14:58 > geschrieben: > > > On 20/07/17 12:01, Wolf

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

2017-07-20 Thread Marcus Wolf
Hi Colin, mine is an aditional patch for an other function, that's pretty similar to the one, you improoved. So we need both patches, yours and mine! Cheers, Marcus > Colin Ian King hat am 20. Juli 2017 um 14:58 > geschrieben: > > > On 20/07/17 12:01, Wolf Entwicklungen wrote: > > Declare

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

2017-07-20 Thread Colin Ian King
On 20/07/17 12:01, Wolf Entwicklungen wrote: > Declare rf69_set_dc_cut_off_frequency_intern as static since it > is used internaly only > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Marcus Wolf > > diff --git a/drivers/staging/pi433/rf69.c

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

2017-07-20 Thread Colin Ian King
On 20/07/17 12:01, Wolf Entwicklungen wrote: > Declare rf69_set_dc_cut_off_frequency_intern as static since it > is used internaly only > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Marcus Wolf > > diff --git a/drivers/staging/pi433/rf69.c

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

2017-07-20 Thread Wolf Entwicklungen
Declare rf69_set_dc_cut_off_frequency_intern as static since it is used internaly only Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Marcus Wolf diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c ---

Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static

2017-07-20 Thread Wolf Entwicklungen
Declare rf69_set_dc_cut_off_frequency_intern as static since it is used internaly only Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Marcus Wolf diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c --- a/drivers/staging/pi433/rf69.c +++