Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Jiri Slaby
Andrew Morton napsal(a): > On Wed, 11 Apr 2007 22:37:03 +0200 > Jiri Slaby <[EMAIL PROTECTED]> wrote: > >> Jiri Slaby napsal(a): >>> Side note, as Danny wrote, there is an asus-laptop driver sitting in -mm, >>> which supersedes this one -- if you plan to push it upstream in the near >>> future, do

Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Andrew Morton
On Wed, 11 Apr 2007 22:37:03 +0200 Jiri Slaby <[EMAIL PROTECTED]> wrote: > Jiri Slaby napsal(a): > > Side note, as Danny wrote, there is an asus-laptop driver sitting in -mm, > > which supersedes this one -- if you plan to push it upstream in the near > > future, don't bother with this patch. > >

Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Jiri Slaby
Jiri Slaby napsal(a): > Side note, as Danny wrote, there is an asus-laptop driver sitting in -mm, > which supersedes this one -- if you plan to push it upstream in the near > future, don't bother with this patch. Hmm, there is a 0.40 version in -rc6 yet. There is something weird with me today. re

Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Jiri Slaby
Andrew Morton napsal(a): > On Wed, 11 Apr 2007 15:04:35 +0200 (CEST) > Jiri Slaby <[EMAIL PROTECTED]> wrote: > >> @@ -706,6 +718,8 @@ static int get_lcd_state(void) >> { >> int lcd = 0; >> >> +BUG_ON(!hotk->methods->lcd_status); > > mutter. We could just warn-and-bale here. > > Hope

Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Andrew Morton
On Wed, 11 Apr 2007 15:04:35 +0200 (CEST) Jiri Slaby <[EMAIL PROTECTED]> wrote: > @@ -706,6 +718,8 @@ static int get_lcd_state(void) > { > int lcd = 0; > > + BUG_ON(!hotk->methods->lcd_status); mutter. We could just warn-and-bale here. Hopefully this is just an is-jiri-sane asserti

Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Danny Kukawka
On Mittwoch, 11. April 2007, Jiri Slaby wrote: > Danny Kukawka napsal(a): > > Btw. looks as if a new version of the driver (v0.41) is already in the > > mm-tree. > > Good to hear, I've got a look only to .21-rc6-mm1, where are no changes like > this (there is 0.30). found in the latest mm snapsh

Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Jiri Slaby
Danny Kukawka napsal(a): > On Mittwoch, 11. April 2007, Danny Kukawka wrote: >> Jiri Slaby wrote: >>> Corentin CHARY napsal(a): Le Wednesday 11 April 2007 11:33:48 Jiri Slaby, vous avez écrit : > asus_acpi, support F2JE model Just use the new asus-laptop driver =) (see acpi4asus-

Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Danny Kukawka
On Mittwoch, 11. April 2007, Danny Kukawka wrote: > Jiri Slaby wrote: > > Corentin CHARY napsal(a): > >> Le Wednesday 11 April 2007 11:33:48 Jiri Slaby, vous avez écrit : > >>> asus_acpi, support F2JE model > >> Just use the new asus-laptop driver =) > >> (see acpi4asus-0.40) > > > > code seems go

Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Danny Kukawka
Jiri Slaby wrote: > Corentin CHARY napsal(a): >> Le Wednesday 11 April 2007 11:33:48 Jiri Slaby, vous avez écrit : >>> asus_acpi, support F2JE model >> Just use the new asus-laptop driver =) >> (see acpi4asus-0.40) > > code seems good, but this is not so good: > #if LINUX_VERSION_CODE >= KERNEL_VE

Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Jiri Slaby
Corentin CHARY napsal(a): > Le Wednesday 11 April 2007 11:33:48 Jiri Slaby, vous avez écrit : >> asus_acpi, support F2JE model > Just use the new asus-laptop driver =) > (see acpi4asus-0.40) code seems good, but this is not so good: #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,20) #warning "This m

Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Corentin CHARY
Le Wednesday 11 April 2007 11:33:48 Jiri Slaby, vous avez écrit : > asus_acpi, support F2JE model Just use the new asus-laptop driver =) (see acpi4asus-0.40) -- CHARY 'Iksaif' Corentin http://xf.iksaif.net - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Jiri Slaby
Jiri Slaby napsal(a): > asus_acpi, support F2JE model Ignore this one, newer version has been sent. regards, -- http://www.fi.muni.cz/~xslaby/Jiri Slaby faculty of informatics, masaryk university, brno, cz e-mail: jirislaby gmail com, gpg pubkey fingerprint: B674 9967 0407 CE62 ACC8

[PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Jiri Slaby
asus_acpi, support F2JE model also augment the driver to support switching LCD status even if no function for getting lcd status exists in DSDT. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 54f13ae12fa0a3e3fc02dda6225baa3436f1e93a tree 70c08fc62a1a2f08ac8cc8f4cf5796a1d6f34764 parent

[PATCH 1/1] ACPI: asus_acpi, support F2JE model

2007-04-11 Thread Jiri Slaby
asus_acpi, support F2JE model also augment the driver to support switching LCD status even if no function for getting lcd status doesn't exist in DSDT. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 4e55effd524fffae1113c301d63d4cd5280264ab tree 96d1c15a7ee82558bcbf1bb4b6e66c435781758d