Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

On Wed, 5 Apr 2017 18:08:08 +0200 Ralph Sennhauser wrote: > Hi Andrew, > > On Wed, 5 Apr 2017 17:50:32 +0200 > Andrew Lunn wrote: > > > > I would say, this is now too late. Changing an interface name > > > > will break configuration scripts. We

Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

On Wed, 5 Apr 2017 18:08:08 +0200 Ralph Sennhauser wrote: > Hi Andrew, > > On Wed, 5 Apr 2017 17:50:32 +0200 > Andrew Lunn wrote: > > > > I would say, this is now too late. Changing an interface name > > > > will break configuration scripts. We are stuck with it. > > > > > > > > > >

Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

Hi Andrew, On Wed, 5 Apr 2017 17:50:32 +0200 Andrew Lunn wrote: > > In fact "internet" label on the case is uppercase, would this matter > > for you for new bindings, or would you still use the lowercase > > version? > > I would use lower case, just to fix with the general

Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

Hi Andrew, On Wed, 5 Apr 2017 17:50:32 +0200 Andrew Lunn wrote: > > In fact "internet" label on the case is uppercase, would this matter > > for you for new bindings, or would you still use the lowercase > > version? > > I would use lower case, just to fix with the general convention that >

Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

> In fact "internet" label on the case is uppercase, would this matter > for you for new bindings, or would you still use the lowercase version? I would use lower case, just to fix with the general convention that interface names are lower case. > > I would say, this is now too late. Changing an

Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

> In fact "internet" label on the case is uppercase, would this matter > for you for new bindings, or would you still use the lowercase version? I would use lower case, just to fix with the general convention that interface names are lower case. > > I would say, this is now too late. Changing an

Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

On Wed, 5 Apr 2017 16:28:24 +0200 Andrew Lunn wrote: > On Wed, Apr 05, 2017 at 07:28:46AM +0200, Ralph Sennhauser wrote: > > The LEDs for the "wan" port are already labeled "mamba:amber:wan" > > resp. "mamba:white:wan". So besides being an outlier with regard to > > the rest of

Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

On Wed, 5 Apr 2017 16:28:24 +0200 Andrew Lunn wrote: > On Wed, Apr 05, 2017 at 07:28:46AM +0200, Ralph Sennhauser wrote: > > The LEDs for the "wan" port are already labeled "mamba:amber:wan" > > resp. "mamba:white:wan". So besides being an outlier with regard to > > the rest of the product line

Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

On Wed, Apr 05, 2017 at 07:28:46AM +0200, Ralph Sennhauser wrote: > The LEDs for the "wan" port are already labeled "mamba:amber:wan" resp. > "mamba:white:wan". So besides being an outlier with regard to the rest > of the product line (see table below) changing the label fixes an > internal

Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

On Wed, Apr 05, 2017 at 07:28:46AM +0200, Ralph Sennhauser wrote: > The LEDs for the "wan" port are already labeled "mamba:amber:wan" resp. > "mamba:white:wan". So besides being an outlier with regard to the rest > of the product line (see table below) changing the label fixes an > internal

[PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

The LEDs for the "wan" port are already labeled "mamba:amber:wan" resp. "mamba:white:wan". So besides being an outlier with regard to the rest of the product line (see table below) changing the label fixes an internal inconsistency as well. This will be visible in user space. Given commit

[PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port

The LEDs for the "wan" port are already labeled "mamba:amber:wan" resp. "mamba:white:wan". So besides being an outlier with regard to the rest of the product line (see table below) changing the label fixes an internal inconsistency as well. This will be visible in user space. Given commit