Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-13 Thread Evgeniy Polyakov
Hi 13.11.2013, 08:07, "David Fries" :   Strong pullup is emulated by driving pin logic high after write   command when   using tri-state push-pull GPIO. > > Acked-by: David Fries > > Looks good to me. Ok, thank you Acked-by: Evgeniy Polyakov Evgeny, can you please resend the wh

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-12 Thread David Fries
On Wed, Nov 13, 2013 at 05:15:52AM +0400, Evgeny Boger wrote: > 11/12/2013 12:01 PM, David Fries: > >On Tue, Nov 12, 2013 at 05:07:14AM +0400, Evgeny Boger wrote: > >>+David Fries > >> > >>Hi David, > >> > >>Would you please comment on this? > > > >On Mon, Nov 11, 2013 at 06:36:54PM +0400, Evgeny

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-12 Thread Evgeny Boger
11/12/2013 12:01 PM, David Fries: On Tue, Nov 12, 2013 at 05:07:14AM +0400, Evgeny Boger wrote: +David Fries Hi David, Would you please comment on this? On Mon, Nov 11, 2013 at 06:36:54PM +0400, Evgeny Boger wrote: Strong pullup is emulated by driving pin logic high after write command

[PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-12 Thread Evgeny Boger
Strong pullup is emulated by driving pin logic high after write command when using tri-state push-pull GPIO. Signed-off-by: Evgeny Boger --- drivers/w1/masters/w1-gpio.c | 22 ++ drivers/w1/w1_int.c | 12 include/linux/w1-gpio.h | 1 + 3 files c

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-12 Thread David Fries
On Tue, Nov 12, 2013 at 05:07:14AM +0400, Evgeny Boger wrote: > +David Fries > > Hi David, > > Would you please comment on this? On Mon, Nov 11, 2013 at 06:36:54PM +0400, Evgeny Boger wrote: > Strong pullup is emulated by driving pin logic high after write > command when > using tri-state p

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-11 Thread Evgeny Boger
+David Fries Hi David, Would you please comment on this? 11/12/2013 05:03 AM, Evgeniy Polyakov: Hi 12.11.2013, 03:32, "Evgeny Boger" : Why did you drop this check? It has nothing with w1-gpio driver This check prevents master from implementing "set_pullup" provided it does support only

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-11 Thread Evgeniy Polyakov
Hi 12.11.2013, 03:32, "Evgeny Boger" : >> Why did you drop this check? It has nothing with w1-gpio driver > This check prevents master from implementing "set_pullup"  provided it does > support only "write_bit" method. > The comment above states that >>  w1_io.c would need to support calling set_

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-11 Thread Evgeniy Polyakov
Hi 11.11.2013, 18:37, "Evgeny Boger" : >  Strong pullup is emulated by driving pin logic high after write command when >  using tri-state push-pull GPIO. > > Signed-off-by: Evgeny Boger > --- >  drivers/w1/masters/w1-gpio.c | 22 ++ >  drivers/w1/w1_int.c  | 12

[PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-11 Thread Evgeny Boger
Strong pullup is emulated by driving pin logic high after write command when using tri-state push-pull GPIO. Signed-off-by: Evgeny Boger --- drivers/w1/masters/w1-gpio.c | 22 ++ drivers/w1/w1_int.c | 12 include/linux/w1-gpio.h | 1 + 3 files c