Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-10 Thread Dan Carpenter
On Thu, Jan 09, 2014 at 09:05:05PM +, KY Srinivasan wrote: > > > > We've had this discussion before where you urge me to trust the host... > > I am just implementing the protocol specification given by the host. If I > cannot trust the > specified protocol, I am not sure what else can be

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-10 Thread Dan Carpenter
On Thu, Jan 09, 2014 at 09:05:05PM +, KY Srinivasan wrote: We've had this discussion before where you urge me to trust the host... I am just implementing the protocol specification given by the host. If I cannot trust the specified protocol, I am not sure what else can be done here.

RE: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread KY Srinivasan
@canonical.com; de...@linuxdriverproject.org > Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service > > On Thu, Jan 09, 2014 at 11:09:21PM +0300, Dan Carpenter wrote: > > We've had this discussion before where you urge me to trust the host... > > > > Problem: This code i

RE: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread KY Srinivasan
@canonical.com; de...@linuxdriverproject.org > Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service > > We've had this discussion before where you urge me to trust the host... I am just implementing the protocol specification given by the host. If I cannot trust the specified protocol,

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread gre...@linuxfoundation.org
On Thu, Jan 09, 2014 at 11:09:21PM +0300, Dan Carpenter wrote: > We've had this discussion before where you urge me to trust the host... > > Problem: This code is racy. > Solution: The host will only send one message at a time. > > Now I have to audit the user space code on the host and I don't

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread Dan Carpenter
We've had this discussion before where you urge me to trust the host... Problem: This code is racy. Solution: The host will only send one message at a time. Now I have to audit the user space code on the host and I don't feel like doing that so you win. I wish we had a better way to do IPC.

RE: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread KY Srinivasan
nical.com; > jasow...@redhat.com > Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service > > On Wed, Jan 08, 2014 at 03:48:35PM -0800, K. Y. Srinivasan wrote: > > Implement the file copy service for Linux guests on Hyper-V. This permits > > the > >

RE: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread KY Srinivasan
Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service > > On Wed, Jan 08, K. Y. Srinivasan wrote: > > > +++ b/tools/hv/hv_fcopy_daemon.c > > > + len = pread(fcopy_fd, buffer, (4096 * 2), 0); > > + > > + if (len <= 0)

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread Olaf Hering
On Wed, Jan 08, K. Y. Srinivasan wrote: > +++ b/tools/hv/hv_fcopy_daemon.c > + len = pread(fcopy_fd, buffer, (4096 * 2), 0); > + > + if (len <= 0) { > + syslog(LOG_ERR, "Read error: %s\n", strerror(errno)); > + continue; This could

RE: [PATCH 2/2] Drivers: hv: balloon: Online the hot-added memory "in context" Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread Victor Miasnikov
Hi! Is there no way we could implement file copying in user space? For "file copy service" "user space" may be pretty good But I ( and other Hyper-V sysadmin) see non-Ok ( in "political correct" terminalogy) results with "hv: balloon: Online the hot-added memory" in "user space" Best

RE: [PATCH 2/2] Drivers: hv: balloon: Online the hot-added memory in context Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread Victor Miasnikov
Hi! Is there no way we could implement file copying in user space? For file copy service user space may be pretty good But I ( and other Hyper-V sysadmin) see non-Ok ( in political correct terminalogy) results with hv: balloon: Online the hot-added memory in user space Best regards,

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread Olaf Hering
On Wed, Jan 08, K. Y. Srinivasan wrote: +++ b/tools/hv/hv_fcopy_daemon.c + len = pread(fcopy_fd, buffer, (4096 * 2), 0); + + if (len = 0) { + syslog(LOG_ERR, Read error: %s\n, strerror(errno)); + continue; This could flood

RE: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread KY Srinivasan
] Drivers: hv: Implement the file copy service On Wed, Jan 08, K. Y. Srinivasan wrote: +++ b/tools/hv/hv_fcopy_daemon.c + len = pread(fcopy_fd, buffer, (4096 * 2), 0); + + if (len = 0) { + syslog(LOG_ERR, Read error: %s\n, strerror(errno

RE: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread KY Srinivasan
Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service On Wed, Jan 08, 2014 at 03:48:35PM -0800, K. Y. Srinivasan wrote: Implement the file copy service for Linux guests on Hyper-V. This permits the host to copy a file (over VMBUS) into the guest. This facility is part

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread Dan Carpenter
We've had this discussion before where you urge me to trust the host... Problem: This code is racy. Solution: The host will only send one message at a time. Now I have to audit the user space code on the host and I don't feel like doing that so you win. I wish we had a better way to do IPC.

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread gre...@linuxfoundation.org
On Thu, Jan 09, 2014 at 11:09:21PM +0300, Dan Carpenter wrote: We've had this discussion before where you urge me to trust the host... Problem: This code is racy. Solution: The host will only send one message at a time. Now I have to audit the user space code on the host and I don't feel

RE: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread KY Srinivasan
Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service We've had this discussion before where you urge me to trust the host... I am just implementing the protocol specification given by the host. If I cannot trust the specified protocol, I am not sure what else can be done here

RE: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-09 Thread KY Srinivasan
...@linuxdriverproject.org Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service On Thu, Jan 09, 2014 at 11:09:21PM +0300, Dan Carpenter wrote: We've had this discussion before where you urge me to trust the host... Problem: This code is racy. Solution: The host will only send one message

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-08 Thread Dan Carpenter
On Wed, Jan 08, 2014 at 03:48:35PM -0800, K. Y. Srinivasan wrote: > Implement the file copy service for Linux guests on Hyper-V. This permits the > host to copy a file (over VMBUS) into the guest. This facility is part of > "guest integration services" supported on the Windows platform. > Here is

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-08 Thread Greg KH
On Wed, Jan 08, 2014 at 03:48:35PM -0800, K. Y. Srinivasan wrote: > Implement the file copy service for Linux guests on Hyper-V. This permits the > host to copy a file (over VMBUS) into the guest. This facility is part of > "guest integration services" supported on the Windows platform. > Here is

[PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-08 Thread K. Y. Srinivasan
Implement the file copy service for Linux guests on Hyper-V. This permits the host to copy a file (over VMBUS) into the guest. This facility is part of "guest integration services" supported on the Windows platform. Here is a link that provides additional details on this functionality:

[PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-08 Thread K. Y. Srinivasan
Implement the file copy service for Linux guests on Hyper-V. This permits the host to copy a file (over VMBUS) into the guest. This facility is part of guest integration services supported on the Windows platform. Here is a link that provides additional details on this functionality:

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-08 Thread Greg KH
On Wed, Jan 08, 2014 at 03:48:35PM -0800, K. Y. Srinivasan wrote: Implement the file copy service for Linux guests on Hyper-V. This permits the host to copy a file (over VMBUS) into the guest. This facility is part of guest integration services supported on the Windows platform. Here is a link

Re: [PATCH 1/1] Drivers: hv: Implement the file copy service

2014-01-08 Thread Dan Carpenter
On Wed, Jan 08, 2014 at 03:48:35PM -0800, K. Y. Srinivasan wrote: Implement the file copy service for Linux guests on Hyper-V. This permits the host to copy a file (over VMBUS) into the guest. This facility is part of guest integration services supported on the Windows platform. Here is a link