Re: [PATCH 1/1] FS/OMFS: block number sanity check during fill_super operation

On Thu, 26 Jun 2014 11:35:57 -0700 Linus Torvalds wrote: > On Jun 26, 2014 11:28 AM, "Fabian Frederick" wrote: > > > >Sorry but I don't see a problem with 2^31 value. > > It's not really 2^31. > > It's *negative* 2^31. > > 1 is "int", so it's a signed number. With the shift it ends up bei

Re: [PATCH 1/1] FS/OMFS: block number sanity check during fill_super operation

On Thu, 26 Jun 2014 10:08:04 -0700 Linus Torvalds wrote: > On Jun 26, 2014 10:05 AM, "Fabian Frederick" wrote: > > > > +#define OMFS_MAX_BLOCKS (1 << 31) > > This is wrong. Think about the types, and what value this has... > Hello Linus, Sorry but I don't see a problem with 2^31 value. It

[PATCH 1/1] FS/OMFS: block number sanity check during fill_super operation

This patch defines maximum block number to 2^31. It also converts bitmap_size and array_size to unsigned int in omfs_get_imap. Suggested-By: Linus Torvalds Suggested-By: Bob Copeland Cc: Linus Torvalds Cc: Bob Copeland Cc: Andrew Morton Signed-off-by: Fabian Frederick --- This is untested.