Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

2012-11-11 Thread Geert Uytterhoeven
On Sun, Nov 4, 2012 at 11:37 PM, Jiri Slaby wrote: > On 11/04/2012 10:06 PM, Geert Uytterhoeven wrote: >> On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby wrote: >>> + if ((quirks & MS_RDESC_3K) && *rsize == 106 && >>> + !memcmp((char []){ 0x19, 0x00, 0x29, 0xff }, >>> +

Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

2012-11-11 Thread Geert Uytterhoeven
On Sun, Nov 4, 2012 at 11:37 PM, Jiri Slaby jsl...@suse.cz wrote: On 11/04/2012 10:06 PM, Geert Uytterhoeven wrote: On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby jsl...@suse.cz wrote: + if ((quirks MS_RDESC_3K) *rsize == 106 + !memcmp((char []){ 0x19, 0x00, 0x29,

Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

2012-11-05 Thread Geert Uytterhoeven
Hi Jiri, On Sun, Nov 4, 2012 at 11:37 PM, Jiri Slaby wrote: > On 11/04/2012 10:06 PM, Geert Uytterhoeven wrote: >> On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby wrote: >>> + if ((quirks & MS_RDESC_3K) && *rsize == 106 && >>> + !memcmp((char []){ 0x19, 0x00, 0x29, 0xff

Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

2012-11-05 Thread Geert Uytterhoeven
Hi Jiri, On Sun, Nov 4, 2012 at 11:37 PM, Jiri Slaby jsl...@suse.cz wrote: On 11/04/2012 10:06 PM, Geert Uytterhoeven wrote: On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby jsl...@suse.cz wrote: + if ((quirks MS_RDESC_3K) *rsize == 106 + !memcmp((char []){ 0x19,

Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

2012-11-04 Thread Jiri Slaby
On 11/04/2012 10:06 PM, Geert Uytterhoeven wrote: > On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby wrote: >> + if ((quirks & MS_RDESC_3K) && *rsize == 106 && >> + !memcmp((char []){ 0x19, 0x00, 0x29, 0xff }, >> + [94], 4)) { > > Which

Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

2012-11-04 Thread Geert Uytterhoeven
On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby wrote: > + if ((quirks & MS_RDESC_3K) && *rsize == 106 && > + !memcmp((char []){ 0x19, 0x00, 0x29, 0xff }, > + [94], 4)) { Which version of gcc are you using? I'm getting (m68k-linux-gnu-gcc

Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

2012-11-04 Thread Geert Uytterhoeven
On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby jsl...@suse.cz wrote: + if ((quirks MS_RDESC_3K) *rsize == 106 + !memcmp((char []){ 0x19, 0x00, 0x29, 0xff }, + rdesc[94], 4)) { Which version of gcc are you using? I'm getting

Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

2012-11-04 Thread Jiri Slaby
On 11/04/2012 10:06 PM, Geert Uytterhoeven wrote: On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby jsl...@suse.cz wrote: + if ((quirks MS_RDESC_3K) *rsize == 106 + !memcmp((char []){ 0x19, 0x00, 0x29, 0xff }, + rdesc[94], 4)) { Which

Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

2012-10-22 Thread Jiri Kosina
On Fri, 19 Oct 2012, Jiri Slaby wrote: > Microsoft Digital Media Keyboard 3000 has two interfaces, and the > second one has a report descriptor with a bug. The second collection > says: > 05 01 -- global; usage page -- 01 -- Generic Desktop Controls > 09 80 -- local; usage -- 80 -- System Control

Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

2012-10-22 Thread Jiri Kosina
On Fri, 19 Oct 2012, Jiri Slaby wrote: Microsoft Digital Media Keyboard 3000 has two interfaces, and the second one has a report descriptor with a bug. The second collection says: 05 01 -- global; usage page -- 01 -- Generic Desktop Controls 09 80 -- local; usage -- 80 -- System Control a1

[PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

2012-10-19 Thread Jiri Slaby
Microsoft Digital Media Keyboard 3000 has two interfaces, and the second one has a report descriptor with a bug. The second collection says: 05 01 -- global; usage page -- 01 -- Generic Desktop Controls 09 80 -- local; usage -- 80 -- System Control a1 01 -- main; collection -- 01 -- application

[PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd

2012-10-19 Thread Jiri Slaby
Microsoft Digital Media Keyboard 3000 has two interfaces, and the second one has a report descriptor with a bug. The second collection says: 05 01 -- global; usage page -- 01 -- Generic Desktop Controls 09 80 -- local; usage -- 80 -- System Control a1 01 -- main; collection -- 01 -- application