Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-11-01 Thread Vojtech Bocek
. = >From be5bbc627e5c8ccfea240deef6a68b10f7f1ff40 Mon Sep 17 00:00:00 2001 From: Vojtech Bocek Date: Thu, 1 Nov 2012 17:34:34 +0100 Subject: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event Initial input ABS events can't reach joydev because it is not opened

Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-11-01 Thread Vojtech Bocek
. = From be5bbc627e5c8ccfea240deef6a68b10f7f1ff40 Mon Sep 17 00:00:00 2001 From: Vojtech Bocek vbo...@gmail.com Date: Thu, 1 Nov 2012 17:34:34 +0100 Subject: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event Initial input ABS events can't reach joydev because

Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-09-13 Thread Vojtech Bocek
2012/9/13, Dmitry Torokhov : > On Wed, Sep 05, 2012 at 10:09:57PM +0200, Vojtěch Boček wrote: > > This makes sense. Just to confirm - have you tried the patch and > verified it works for you? > > Thanks. > > -- > Dmitry > Yes, I did. Only one thing is incorrect(?). When I plug the joystick in,

Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-09-13 Thread Vojtech Bocek
2012/9/13, Dmitry Torokhov dmitry.torok...@gmail.com: On Wed, Sep 05, 2012 at 10:09:57PM +0200, Vojtěch Boček wrote: This makes sense. Just to confirm - have you tried the patch and verified it works for you? Thanks. -- Dmitry Yes, I did. Only one thing is incorrect(?). When I plug the

Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-09-12 Thread Dmitry Torokhov
On Wed, Sep 05, 2012 at 10:09:57PM +0200, Vojtěch Boček wrote: > Hi, > > 2012/9/5 Dmitry Torokhov > > So what guarantees that joystick events will arrive in time, before > > joydev_generate_startup_event() is called? It looks like your solution > > is racy... > > > > I wonder if we should not

Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-09-12 Thread Dmitry Torokhov
On Wed, Sep 05, 2012 at 10:09:57PM +0200, Vojtěch Boček wrote: Hi, 2012/9/5 Dmitry Torokhov dmitry.torok...@gmail.com So what guarantees that joystick events will arrive in time, before joydev_generate_startup_event() is called? It looks like your solution is racy... I wonder if we

Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-09-05 Thread Vojtěch Boček
Hi, 2012/9/5 Dmitry Torokhov > So what guarantees that joystick events will arrive in time, before > joydev_generate_startup_event() is called? It looks like your solution > is racy... > > I wonder if we should not generate the startup event until we have seen > at least one EV_SYN, i.e. entire

Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-09-05 Thread Vojtěch Boček
Hi, 2012/9/5 Dmitry Torokhov dmitry.torok...@gmail.com So what guarantees that joystick events will arrive in time, before joydev_generate_startup_event() is called? It looks like your solution is racy... I wonder if we should not generate the startup event until we have seen at least one

Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-09-04 Thread Dmitry Torokhov
Hi Vojtech, On Tue, Aug 14, 2012 at 12:11:54AM +0200, Vojtech Bocek wrote: > Initial input event has not yet arrived in joydev_connect() > where values are set, which means default values of input_absinfo > are used for init event, not the actual values from joystick. So what guarantees that

Re: [PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-09-04 Thread Dmitry Torokhov
Hi Vojtech, On Tue, Aug 14, 2012 at 12:11:54AM +0200, Vojtech Bocek wrote: Initial input event has not yet arrived in joydev_connect() where values are set, which means default values of input_absinfo are used for init event, not the actual values from joystick. So what guarantees that

[PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-08-13 Thread Vojtech Bocek
Initial input event has not yet arrived in joydev_connect() where values are set, which means default values of input_absinfo are used for init event, not the actual values from joystick. Signed-off-by: Vojtech Bocek --- drivers/input/joydev.c |9 +++-- 1 file changed, 7 insertions(+),

[PATCH 1/1] Input: joydev - fix axes values sent in initial js_event

2012-08-13 Thread Vojtech Bocek
Initial input event has not yet arrived in joydev_connect() where values are set, which means default values of input_absinfo are used for init event, not the actual values from joystick. Signed-off-by: Vojtech Bocek vbo...@gmail.com --- drivers/input/joydev.c |9 +++-- 1 file changed, 7