Re: [PATCH 1/1] PCI/AER: Change to use helper pcie_aer_is_native() in some places

2021-02-04 Thread tanxiaofei
Hi Krzysztof, On 2021/2/5 5:50, Krzysztof Wilczyński wrote: Hi Tan, This is very nice! Thank you for this. [...] if (dev->aer_cap && pci_aer_available() && - (pcie_ports_native || host->native_aer)) { + pcie_aer_is_native(dev)) { services |=

Re: [PATCH 1/1] PCI/AER: Change to use helper pcie_aer_is_native() in some places

2021-02-04 Thread Krzysztof Wilczyński
Hi Tan, This is very nice! Thank you for this. [...] > if (dev->aer_cap && pci_aer_available() && > - (pcie_ports_native || host->native_aer)) { > + pcie_aer_is_native(dev)) { > services |= PCIE_PORT_SERVICE_AER; [...] A suggestion. You could improve this

[PATCH 1/1] PCI/AER: Change to use helper pcie_aer_is_native() in some places

2021-02-03 Thread Xiaofei Tan
Use helper function pcie_aer_is_native() in some places to keep the code tidy. No function changes. Signed-off-by: Xiaofei Tan --- drivers/pci/pcie/aer.c | 4 ++-- drivers/pci/pcie/err.c | 2 +- drivers/pci/pcie/portdrv_core.c | 2 +- 3 files changed, 4 insertions(+), 4