Re: [PATCH 1/1] Revert "affs: use ->kill_sb() to simplify ->put_super() and failure exits of ->mount()"

2014-04-29 Thread Fabian Frederick
On Tue, 29 Apr 2014 15:30:22 -0700 Andrew Morton wrote: > On Tue, 29 Apr 2014 21:35:12 +0200 Fabian Frederick wrote: > > > This reverts commit 842a859db26b70 due to permanent crash issues. > > > > Sample scenario: > > > > dd if=/dev/zero of=f1 bs=1M count=1 > > losetup -f f1 > > mount -t

Re: [PATCH 1/1] Revert "affs: use ->kill_sb() to simplify ->put_super() and failure exits of ->mount()"

2014-04-29 Thread Andrew Morton
On Tue, 29 Apr 2014 21:35:12 +0200 Fabian Frederick wrote: > This reverts commit 842a859db26b70 due to permanent crash issues. > > Sample scenario: > > dd if=/dev/zero of=f1 bs=1M count=1 > losetup -f f1 > mount -t affs -o unknownoption /dev/loop0 mnt1 > -> crash Thanks for the bug report ;)

[PATCH 1/1] Revert "affs: use ->kill_sb() to simplify ->put_super() and failure exits of ->mount()"

2014-04-29 Thread Fabian Frederick
This reverts commit 842a859db26b70 due to permanent crash issues. Sample scenario: dd if=/dev/zero of=f1 bs=1M count=1 losetup -f f1 mount -t affs -o unknownoption /dev/loop0 mnt1 -> crash With patch revert: "mount: wrong fs type, bad option, bad superblock on /dev/loop0" Cc: Alexander Viro

[PATCH 1/1] Revert affs: use -kill_sb() to simplify -put_super() and failure exits of -mount()

2014-04-29 Thread Fabian Frederick
This reverts commit 842a859db26b70 due to permanent crash issues. Sample scenario: dd if=/dev/zero of=f1 bs=1M count=1 losetup -f f1 mount -t affs -o unknownoption /dev/loop0 mnt1 - crash With patch revert: mount: wrong fs type, bad option, bad superblock on /dev/loop0 Cc: Alexander Viro

Re: [PATCH 1/1] Revert affs: use -kill_sb() to simplify -put_super() and failure exits of -mount()

2014-04-29 Thread Andrew Morton
On Tue, 29 Apr 2014 21:35:12 +0200 Fabian Frederick f...@skynet.be wrote: This reverts commit 842a859db26b70 due to permanent crash issues. Sample scenario: dd if=/dev/zero of=f1 bs=1M count=1 losetup -f f1 mount -t affs -o unknownoption /dev/loop0 mnt1 - crash Thanks for the bug

Re: [PATCH 1/1] Revert affs: use -kill_sb() to simplify -put_super() and failure exits of -mount()

2014-04-29 Thread Fabian Frederick
On Tue, 29 Apr 2014 15:30:22 -0700 Andrew Morton a...@linux-foundation.org wrote: On Tue, 29 Apr 2014 21:35:12 +0200 Fabian Frederick f...@skynet.be wrote: This reverts commit 842a859db26b70 due to permanent crash issues. Sample scenario: dd if=/dev/zero of=f1 bs=1M count=1