RE: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C V1.2.0

2012-11-15 Thread Rusty Russell
Mathias LEBLANC writes: > Variable interrupts value must be 0 or 1. This restriction is defined by the > fact of using the bool parameter (true or false) But you can't pass an int to module_param(..., bool,...). Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-

RE: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C V1.2.0

2012-11-12 Thread Mathias LEBLANC
; Rajiv Andrade; Marcel Selhorst; Sirrix AG; tpmdd-de...@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org; Jean-Luc BLANC; Mathias LEBLANC Subject: Re: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C V1.2.0 Mathias Leblanc writes: > +static int interrupts ; > +module_param(interrupts, bool

Re: [PATCH 1/1] TPM: STMicroelectronics ST33 I2C V1.2.0

2012-11-08 Thread Rusty Russell
Mathias Leblanc writes: > +static int interrupts ; > +module_param(interrupts, bool, 0444); > +MODULE_PARM_DESC(interrupts, "Enable interrupts"); > + > +static int power_mgt = 1; > +module_param(power_mgt, bool, 0444); > +MODULE_PARM_DESC(power_mgt, "Power Management"); These are not bools, so wh

[PATCH 1/1] TPM: STMicroelectronics ST33 I2C V1.2.0

2012-11-07 Thread Mathias Leblanc
* STMicroelectronics version 1.2.0, Copyright (C) 2010 * STMicroelectronics comes with ABSOLUTELY NO WARRANTY. * This is free software, and you are welcome to redistribute it * under certain conditions. This is the driver for TPM chip from ST Microelectronics. If you have a TPM security chip