Re: [PATCH 1/1] TTY Fix NULL pointer error in tty_wakeup

2013-03-31 Thread Greg Kroah-Hartman
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Sun, Mar 31, 2013 at 04:09:05PM +0800, frankie lin wrote: > Hi, greg, it's excited to get your reply. > In our case, it is gs_start_io(struct gs_port *port) in the file u_serial.c > who > call the

Re: [PATCH 1/1] TTY Fix NULL pointer error in tty_wakeup

2013-03-30 Thread Greg Kroah-Hartman
On Sat, Mar 30, 2013 at 03:58:43PM +0800, Frankie Lin wrote: > When calling tty_wakeup and the parameter is NULL,the oops will happen. Who is calling that function with NULL? Shouldn't that be fixed instead? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-ker

[PATCH 1/1] TTY Fix NULL pointer error in tty_wakeup

2013-03-30 Thread Frankie Lin
When calling tty_wakeup and the parameter is NULL,the oops will happen. The virtual address &tty->flags can not be handled in the kernel space, while PC goto test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags). Tested on ARM Machine msm8625. Signed-off-by: Frankie Lin --- drivers/tty/tty_io.c |5 +++