Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-19 Thread Yinghai Lu
On Fri, Oct 19, 2012 at 1:49 AM, Tang Chen wrote: > Is it just container and pci_root_bridge hot-remove need to call > acpi_bus_trim() twice ? For normal device without sub-device, I think > it is OK to call acpi_bus_trim(device, 1). > > The reason why I'm asking this question is: > > I saw in

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-19 Thread Tang Chen
On 10/18/2012 12:28 AM, Yinghai Lu wrote: On Wed, Oct 17, 2012 at 12:39 AM, Tang Chen wrote: On 10/17/2012 01:18 PM, Yinghai Lu wrote: And also, I have another 2 questions, maybe you can help me. 1) Do we need to put PNP0A08 into acpi_pci_roots ? looks like we need to unify those two ids.

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-19 Thread Tang Chen
On 10/18/2012 12:28 AM, Yinghai Lu wrote: On Wed, Oct 17, 2012 at 12:39 AM, Tang Chentangc...@cn.fujitsu.com wrote: On 10/17/2012 01:18 PM, Yinghai Lu wrote: And also, I have another 2 questions, maybe you can help me. 1) Do we need to put PNP0A08 into acpi_pci_roots ? looks like we need to

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-19 Thread Yinghai Lu
On Fri, Oct 19, 2012 at 1:49 AM, Tang Chen tangc...@cn.fujitsu.com wrote: Is it just container and pci_root_bridge hot-remove need to call acpi_bus_trim() twice ? For normal device without sub-device, I think it is OK to call acpi_bus_trim(device, 1). The reason why I'm asking this question

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-17 Thread Tang Chen
On 10/18/2012 12:28 AM, Yinghai Lu wrote: On Wed, Oct 17, 2012 at 12:39 AM, Tang Chen wrote: On 10/17/2012 01:18 PM, Yinghai Lu wrote: And also, I have another 2 questions, maybe you can help me. 1) Do we need to put PNP0A08 into acpi_pci_roots ? looks like we need to unify those two ids.

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-17 Thread Yinghai Lu
On Wed, Oct 17, 2012 at 12:39 AM, Tang Chen wrote: > On 10/17/2012 01:18 PM, Yinghai Lu wrote: > > And also, I have another 2 questions, maybe you can help me. > 1) Do we need to put PNP0A08 into acpi_pci_roots ? looks like we need to unify those two ids. > 2) In container_notify_cb(), when it

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-17 Thread Tang Chen
On 10/17/2012 03:39 PM, Tang Chen wrote: On 10/17/2012 01:18 PM, Yinghai Lu wrote: no, we don't need that. after closely looking, it seems we can dump acpi_root_bridge. please check if attached patch could work with container path. Hi Yinghai, Your patch seems working well. BTW, I

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-17 Thread Tang Chen
On 10/17/2012 01:18 PM, Yinghai Lu wrote: no, we don't need that. after closely looking, it seems we can dump acpi_root_bridge. please check if attached patch could work with container path. Hi Yinghai, Your patch seems working well. BTW, I actually found that the two lists,

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-17 Thread Tang Chen
On 10/17/2012 01:18 PM, Yinghai Lu wrote: no, we don't need that. after closely looking, it seems we can dump acpi_root_bridge. please check if attached patch could work with container path. Hi Yinghai, Your patch seems working well. BTW, I actually found that the two lists,

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-17 Thread Tang Chen
On 10/17/2012 03:39 PM, Tang Chen wrote: On 10/17/2012 01:18 PM, Yinghai Lu wrote: no, we don't need that. after closely looking, it seems we can dump acpi_root_bridge. please check if attached patch could work with container path. Hi Yinghai, Your patch seems working well. BTW, I

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-17 Thread Yinghai Lu
On Wed, Oct 17, 2012 at 12:39 AM, Tang Chen tangc...@cn.fujitsu.com wrote: On 10/17/2012 01:18 PM, Yinghai Lu wrote: And also, I have another 2 questions, maybe you can help me. 1) Do we need to put PNP0A08 into acpi_pci_roots ? looks like we need to unify those two ids. 2) In

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-17 Thread Tang Chen
On 10/18/2012 12:28 AM, Yinghai Lu wrote: On Wed, Oct 17, 2012 at 12:39 AM, Tang Chentangc...@cn.fujitsu.com wrote: On 10/17/2012 01:18 PM, Yinghai Lu wrote: And also, I have another 2 questions, maybe you can help me. 1) Do we need to put PNP0A08 into acpi_pci_roots ? looks like we need to

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-16 Thread Yinghai Lu
On Tue, Oct 16, 2012 at 8:25 PM, Tang Chen wrote: > Hi Yinghai, > > List acpi_root_bridge_list is only updated when kernel is booting, > or in _handle_hotplug_event_root() when handling ACPI_NOTIFY_DEVICE_CHECK > event on a pci root bridge device. But when we hotplug a container, which > contains

[PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-16 Thread Tang Chen
Hi Yinghai, List acpi_root_bridge_list is only updated when kernel is booting, or in _handle_hotplug_event_root() when handling ACPI_NOTIFY_DEVICE_CHECK event on a pci root bridge device. But when we hotplug a container, which contains one or more pci root bridges, container_notify_cb() will be

[PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-16 Thread Tang Chen
Hi Yinghai, List acpi_root_bridge_list is only updated when kernel is booting, or in _handle_hotplug_event_root() when handling ACPI_NOTIFY_DEVICE_CHECK event on a pci root bridge device. But when we hotplug a container, which contains one or more pci root bridges, container_notify_cb() will be

Re: [PATCH 1/1] Update acpi_root_bridge_list in container hotplug path.

2012-10-16 Thread Yinghai Lu
On Tue, Oct 16, 2012 at 8:25 PM, Tang Chen tangc...@cn.fujitsu.com wrote: Hi Yinghai, List acpi_root_bridge_list is only updated when kernel is booting, or in _handle_hotplug_event_root() when handling ACPI_NOTIFY_DEVICE_CHECK event on a pci root bridge device. But when we hotplug a