Re: [PATCH 1/1] block: move the PAGE_SECTORS definition into

2020-11-19 Thread Leizhen (ThunderTown)
On 2020/11/20 9:27, John Dorminy wrote: > Greetings; > > There are a lot of uses of PAGE_SIZE/SECTOR_SIZE scattered around, and > it seems like a medium improvement to be able to refer to it as > PAGE_SECTORS everywhere instead of just inside dm, bcache, and > null_blk. Did this change

Re: [PATCH 1/1] block: move the PAGE_SECTORS definition into

2020-11-19 Thread John Dorminy
Greetings; There are a lot of uses of PAGE_SIZE/SECTOR_SIZE scattered around, and it seems like a medium improvement to be able to refer to it as PAGE_SECTORS everywhere instead of just inside dm, bcache, and null_blk. Did this change progress forward somewhere? Thanks! John Dorminy On Mon,

Re: [PATCH 1/1] block: move the PAGE_SECTORS definition into

2020-09-07 Thread Leizhen (ThunderTown)
Hi, Jens Axboe, Alasdair Kergon, Mike Snitzer: What's your opinion? On 2020/8/21 15:05, Coly Li wrote: > On 2020/8/21 14:48, Leizhen (ThunderTown) wrote: >> >> >> On 8/21/2020 12:11 PM, Coly Li wrote: >>> On 2020/8/21 10:03, Zhen Lei wrote: There are too many PAGE_SECTORS definitions, and

Re: [PATCH 1/1] block: move the PAGE_SECTORS definition into

2020-08-21 Thread Coly Li
On 2020/8/21 14:48, Leizhen (ThunderTown) wrote: > > > On 8/21/2020 12:11 PM, Coly Li wrote: >> On 2020/8/21 10:03, Zhen Lei wrote: >>> There are too many PAGE_SECTORS definitions, and all of them are the >>> same. It looks a bit of a mess. So why not move it into , >>> to achieve a basic and

Re: [PATCH 1/1] block: move the PAGE_SECTORS definition into

2020-08-21 Thread Leizhen (ThunderTown)
On 8/21/2020 12:11 PM, Coly Li wrote: > On 2020/8/21 10:03, Zhen Lei wrote: >> There are too many PAGE_SECTORS definitions, and all of them are the >> same. It looks a bit of a mess. So why not move it into , >> to achieve a basic and unique definition. >> >> Signed-off-by: Zhen Lei > > > A

Re: [PATCH 1/1] block: move the PAGE_SECTORS definition into

2020-08-20 Thread Coly Li
On 2020/8/21 10:03, Zhen Lei wrote: > There are too many PAGE_SECTORS definitions, and all of them are the > same. It looks a bit of a mess. So why not move it into , > to achieve a basic and unique definition. > > Signed-off-by: Zhen Lei A lazy question about page size > 4KB: currently in

[PATCH 1/1] block: move the PAGE_SECTORS definition into

2020-08-20 Thread Zhen Lei
There are too many PAGE_SECTORS definitions, and all of them are the same. It looks a bit of a mess. So why not move it into , to achieve a basic and unique definition. Signed-off-by: Zhen Lei --- drivers/block/brd.c | 1 - drivers/block/null_blk_main.c | 1 - drivers/md/bcache/util.h