Re: [PATCH 1/1] brcmfmac: fix pmksa->bssid usage

2016-08-23 Thread Nicolas Iooss
On 22/08/16 21:38, Arend Van Spriel wrote: > On 22-8-2016 15:03, Nicolas Iooss wrote: >> On 05/08/16 22:34, Nicolas Iooss wrote: [...] >>> Fixes: 6c404f34f2bd ("brcmfmac: Cleanup pmksa cache handling code") >>> Cc: sta...@ger.kernel.org > > Ah, so you did something wrong after all :-p. The email

Re: [PATCH 1/1] brcmfmac: fix pmksa->bssid usage

2016-08-23 Thread Nicolas Iooss
On 22/08/16 21:38, Arend Van Spriel wrote: > On 22-8-2016 15:03, Nicolas Iooss wrote: >> On 05/08/16 22:34, Nicolas Iooss wrote: [...] >>> Fixes: 6c404f34f2bd ("brcmfmac: Cleanup pmksa cache handling code") >>> Cc: sta...@ger.kernel.org > > Ah, so you did something wrong after all :-p. The email

Re: [PATCH 1/1] brcmfmac: fix pmksa->bssid usage

2016-08-22 Thread Arend Van Spriel
On 22-8-2016 15:03, Nicolas Iooss wrote: > Hello, > > After I sent the following patch a few weeks ago, I have not received > any feedback. Could you please review it and tell me what I may have > done wrong? Nothing. People went on vacation :-) > Thanks, > Nicolas > > On 05/08/16 22:34,

Re: [PATCH 1/1] brcmfmac: fix pmksa->bssid usage

2016-08-22 Thread Arend Van Spriel
On 22-8-2016 15:03, Nicolas Iooss wrote: > Hello, > > After I sent the following patch a few weeks ago, I have not received > any feedback. Could you please review it and tell me what I may have > done wrong? Nothing. People went on vacation :-) > Thanks, > Nicolas > > On 05/08/16 22:34,

Re: [PATCH 1/1] brcmfmac: fix pmksa->bssid usage

2016-08-22 Thread Rafał Miłecki
On 22 August 2016 at 15:03, Nicolas Iooss wrote: > After I sent the following patch a few weeks ago, I have not received > any feedback. Could you please review it and tell me what I may have > done wrong?

Re: [PATCH 1/1] brcmfmac: fix pmksa->bssid usage

2016-08-22 Thread Rafał Miłecki
On 22 August 2016 at 15:03, Nicolas Iooss wrote: > After I sent the following patch a few weeks ago, I have not received > any feedback. Could you please review it and tell me what I may have > done wrong?

Re: [PATCH 1/1] brcmfmac: fix pmksa->bssid usage

2016-08-22 Thread Nicolas Iooss
Hello, After I sent the following patch a few weeks ago, I have not received any feedback. Could you please review it and tell me what I may have done wrong? Thanks, Nicolas On 05/08/16 22:34, Nicolas Iooss wrote: > The struct cfg80211_pmksa defines its bssid field as: > > const u8 *bssid;

Re: [PATCH 1/1] brcmfmac: fix pmksa->bssid usage

2016-08-22 Thread Nicolas Iooss
Hello, After I sent the following patch a few weeks ago, I have not received any feedback. Could you please review it and tell me what I may have done wrong? Thanks, Nicolas On 05/08/16 22:34, Nicolas Iooss wrote: > The struct cfg80211_pmksa defines its bssid field as: > > const u8 *bssid;

[PATCH 1/1] brcmfmac: fix pmksa->bssid usage

2016-08-05 Thread Nicolas Iooss
The struct cfg80211_pmksa defines its bssid field as: const u8 *bssid; contrary to struct brcmf_pmksa, which uses: u8 bssid[ETH_ALEN]; Therefore in brcmf_cfg80211_del_pmksa(), >bssid takes the address of this field (of type u8**), not the one of its content (which would be u8*).

[PATCH 1/1] brcmfmac: fix pmksa->bssid usage

2016-08-05 Thread Nicolas Iooss
The struct cfg80211_pmksa defines its bssid field as: const u8 *bssid; contrary to struct brcmf_pmksa, which uses: u8 bssid[ETH_ALEN]; Therefore in brcmf_cfg80211_del_pmksa(), >bssid takes the address of this field (of type u8**), not the one of its content (which would be u8*).