Re: [PATCH 1/1] ceph: do not modify fi->frag in need_reset_readdir()

2016-08-28 Thread Yan, Zheng
> On Aug 29, 2016, at 00:47, Nicolas Iooss wrote: > > Commit f3c4ebe65ea1 ("ceph: using hash value to compose dentry offset") > modified "if (fpos_frag(new_pos) != fi->frag)" to "if (fi->frag |= > fpos_frag(new_pos))" in need_reset_readdir(), thus replacing a > comparison operator with an assign

[PATCH 1/1] ceph: do not modify fi->frag in need_reset_readdir()

2016-08-28 Thread Nicolas Iooss
Commit f3c4ebe65ea1 ("ceph: using hash value to compose dentry offset") modified "if (fpos_frag(new_pos) != fi->frag)" to "if (fi->frag |= fpos_frag(new_pos))" in need_reset_readdir(), thus replacing a comparison operator with an assignment one. This looks like a typo which is reported by clang wh