Re: [PATCH 1/1] char: hpet: Remove unused local variable 'm' in hpet_interrupt()

2021-04-15 Thread Leizhen (ThunderTown)
On 2021/4/15 22:53, Greg Kroah-Hartman wrote: > On Thu, Apr 15, 2021 at 10:24:04PM +0800, Zhen Lei wrote: >> Commit 273ef9509b79 ("drivers/char/hpet.c: fix periodic-emulation for >> delayed interrupt") removed the reference to local variable 'm', but >> forgot to remove the definition and

Re: [PATCH 1/1] char: hpet: Remove unused local variable 'm' in hpet_interrupt()

2021-04-15 Thread Greg Kroah-Hartman
On Thu, Apr 15, 2021 at 10:24:04PM +0800, Zhen Lei wrote: > Commit 273ef9509b79 ("drivers/char/hpet.c: fix periodic-emulation for > delayed interrupt") removed the reference to local variable 'm', but > forgot to remove the definition and assignment of it. Due to > read_counter() indirectly calls

[PATCH 1/1] char: hpet: Remove unused local variable 'm' in hpet_interrupt()

2021-04-15 Thread Zhen Lei
Commit 273ef9509b79 ("drivers/char/hpet.c: fix periodic-emulation for delayed interrupt") removed the reference to local variable 'm', but forgot to remove the definition and assignment of it. Due to read_counter() indirectly calls "read barrier", the performance is slightly degraded. Since the