Re: [PATCH 1/1] clk: tegra: fix WARN_ON in PLL_RE registration

2015-05-18 Thread bilhuang
On 05/16/2015 01:12 AM, Benson Leung wrote: On Fri, May 15, 2015 at 5:07 AM, Bill Huang wrote: This fixes two things. - Read the correct IDDQ register - Check the correct IDDQ bit position Signed-off-by: Bill Huang Reviewed-by: Benson Leung By the way, does it also make sense to do the

Re: [PATCH 1/1] clk: tegra: fix WARN_ON in PLL_RE registration

2015-05-18 Thread bilhuang
On 05/16/2015 01:12 AM, Benson Leung wrote: On Fri, May 15, 2015 at 5:07 AM, Bill Huang bilhu...@nvidia.com wrote: This fixes two things. - Read the correct IDDQ register - Check the correct IDDQ bit position Signed-off-by: Bill Huang bilhu...@nvidia.com Reviewed-by: Benson Leung

Re: [PATCH 1/1] clk: tegra: fix WARN_ON in PLL_RE registration

2015-05-15 Thread Benson Leung
On Fri, May 15, 2015 at 5:07 AM, Bill Huang wrote: > This fixes two things. > > - Read the correct IDDQ register > - Check the correct IDDQ bit position > > Signed-off-by: Bill Huang Reviewed-by: Benson Leung By the way, does it also make sense to do the same thing for

[PATCH 1/1] clk: tegra: fix WARN_ON in PLL_RE registration

2015-05-15 Thread Bill Huang
This fixes two things. - Read the correct IDDQ register - Check the correct IDDQ bit position Signed-off-by: Bill Huang --- drivers/clk/tegra/clk-pll.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c index

[PATCH 1/1] clk: tegra: fix WARN_ON in PLL_RE registration

2015-05-15 Thread Bill Huang
This fixes two things. - Read the correct IDDQ register - Check the correct IDDQ bit position Signed-off-by: Bill Huang bilhu...@nvidia.com --- drivers/clk/tegra/clk-pll.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-pll.c

Re: [PATCH 1/1] clk: tegra: fix WARN_ON in PLL_RE registration

2015-05-15 Thread Benson Leung
On Fri, May 15, 2015 at 5:07 AM, Bill Huang bilhu...@nvidia.com wrote: This fixes two things. - Read the correct IDDQ register - Check the correct IDDQ bit position Signed-off-by: Bill Huang bilhu...@nvidia.com Reviewed-by: Benson Leung ble...@chromium.org By the way, does it also make